Code review - Issue 129078: add support for precompilation-enabledhttps://codereview.appspot.com/2009-10-16T19:09:39+00:00rietveld
Message from unknown
2009-10-14T02:24:33+00:00woodieurn:md5:7ac5aeb8faf27074e23ccd9646f3edca
Message from mando.woodie@gmail.com
2009-10-14T02:44:10+00:00woodieurn:md5:5d714f461365ad45e30f0597f31365bd
this seems to work
http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):
http://codereview.appspot.com/129078/diff/1/3#newcode97
Line 97: attr_accessor :application, :inbound_services, :precompilation_enabled
had trouble with the dafault value
when I only assigned attr_writer
http://codereview.appspot.com/129078/diff/1/3#newcode106
Line 106: 'jruby.compile.lazyHandles' => true,
as long as we do the packaging, and we get some savings...
Message from unknown
2009-10-14T05:47:26+00:00woodieurn:md5:d350a4657e1e330f635dfeaa62adc178
Message from mando.woodie@gmail.com
2009-10-14T05:50:34+00:00woodieurn:md5:43c438264539ab69e23e8ddbf44f7cd4
http://codereview.appspot.com/129078/diff/1004/6
File appengine-rack/lib/appengine-rack.rb (right):
http://codereview.appspot.com/129078/diff/1004/6#newcode106
Line 106: # 'jruby.compile.lazyHandles' => true,
I cannot imagine that the savings here
could be worth the added complexity
Message from unknown
2009-10-15T08:25:03+00:00woodieurn:md5:d33df43ac98c79faa26667974368fe14
Message from unknown
2009-10-15T08:27:33+00:00woodieurn:md5:029125630854e9c094ccf66facd83b4d
Message from mando.woodie@gmail.com
2009-10-15T08:30:19+00:00woodieurn:md5:48bc116f9c8af4004cdf2a002cee6676
you sdk rakefile is remarkable
http://codereview.appspot.com/129078/diff/1006/2009
File appengine-rack/lib/appengine-rack.rb (right):
http://codereview.appspot.com/129078/diff/1006/2009#newcode106
Line 106: # 'jruby.compile.lazyHandles' => true,
seems reasonable to leave this in there for now
Message from unknown
2009-10-15T09:03:06+00:00woodieurn:md5:3c4498719c87940e595b5d2ce7793674
Message from unknown
2009-10-15T22:06:26+00:00woodieurn:md5:109cb7c2c356f93512e463431c3cd67c
Message from unknown
2009-10-15T22:08:16+00:00woodieurn:md5:b54e40e34a8fd8dfb762b3cdc39b1594
Message from unknown
2009-10-15T22:24:24+00:00woodieurn:md5:50246432df4d5403cbba4f5e2714b026
Message from mando.woodie@gmail.com
2009-10-15T22:31:33+00:00woodieurn:md5:52f151949180f7292691e2a22522aa1d
Still testing, but it all seems to work.
I'd like to drop the listener this release, worth the wait!
http://codereview.appspot.com/129078/diff/2034/1031
File appengine-tools/lib/appengine-tools/web-xml.rb (right):
http://codereview.appspot.com/129078/diff/2034/1031#newcode44
Line 44: # TODO: we need a servlet that calls LoadOnFirstRequestApplicationFactory
this is the killer feature for this release,
and will focus our users in the right direction
Message from unknown
2009-10-16T06:37:28+00:00woodieurn:md5:ac397209e1ff1aaedf7c313f2362bebb
Message from unknown
2009-10-16T11:02:33+00:00woodieurn:md5:ff709dc9fbd5b5d445ed94b081b36f66
Message from mando.woodie@gmail.com
2009-10-16T11:16:44+00:00woodieurn:md5:34ac51da770366a53916bb3ef27d298e
This is a very exciting release!
You need to get the LazyContextListener working,
but I can see Rubyists building chunks in Duby.
I'm going to also build some of my stuff as Ruby CGI.
We should also ship a RubyCGI servlet. I hope we can
have a cgi folder, the mapped path defines the filename
http://codereview.appspot.com/129078/diff/1047/2041
File appengine-rack/src/build.sh (right):
http://codereview.appspot.com/129078/diff/1047/2041#newcode4
Line 4: export CLASSPATH=$JRUBY_RACK:servlet.jar:.
I grabbed a REALLY old version of servlet.jar
I suppose this build can require that you have the sdk
I figure I can roll this into the Rakefile
once duby and bitescript gems are available
http://codereview.appspot.com/129078/diff/1047/2049
File appengine-tools/lib/appengine-tools/bundler.rb (right):
http://codereview.appspot.com/129078/diff/1047/2049#newcode82
Line 82: JRUBY_RACK_URL = "http://kenai.com/downloads/jruby-rack/#{JRUBY_RACK}"
this is the new URL, old one redirects
http://codereview.appspot.com/129078/diff/1047/2051
File appengine-tools/lib/appengine-tools/update_check.rb (right):
http://codereview.appspot.com/129078/diff/1047/2051#newcode83
Line 83: puts "=> Please run #{prefix} gem update #{name}."
normal messages should have the '=>' prefix
errors should not, not sure which this is.
http://codereview.appspot.com/129078/diff/1047/2052
File appengine-tools/lib/appengine-tools/web-xml.rb (right):
http://codereview.appspot.com/129078/diff/1047/2052#newcode44
Line 44: use JavaContextListener, 'com.google.appengine.jruby.LazyContextListener'
maybe this should ship with our Java SDK
Message from ribrdb@gmail.com
2009-10-16T16:36:39+00:00do_not_useurn:md5:e2611ce03dbd7921be6feb874d222e43
The CGI stuff is not ready to be released. If we really do need to release it, we need to spend some time making it better.
http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):
http://codereview.appspot.com/129078/diff/1/3#newcode125
Line 125: def precompilation_enabled?
How about adding an enable_precompilation method too?
http://codereview.appspot.com/129078/diff/1047/2041
File appengine-rack/src/build.sh (right):
http://codereview.appspot.com/129078/diff/1047/2041#newcode4
Line 4: export CLASSPATH=$JRUBY_RACK:servlet.jar:.
Maybe we should just include the .class files for now, because of the dependencies? Also, I think it would be better to put this stuff in the jruby jar than here.
On 2009/10/16 11:16:44, woodie wrote:
> I grabbed a REALLY old version of servlet.jar
> I suppose this build can require that you have the sdk
>
> I figure I can roll this into the Rakefile
> once duby and bitescript gems are available
>
http://codereview.appspot.com/129078/diff/1047/2054
File jruby-abridged/Rakefile (right):
http://codereview.appspot.com/129078/diff/1047/2054#newcode82
Line 82: cp_r(File.join(ROOT, '..', 'appengine-rack', 'src',
If they're going into this jar, I think the source files should be in this directory.
Message from unknown
2009-10-16T18:56:04+00:00woodieurn:md5:c68da4cd9b92f9d9d6b95a101788f6a6
Message from ribrdb@gmail.com
2009-10-16T19:09:39+00:00do_not_useurn:md5:01d483d20b8157ad1e154c4f28097302
http://codereview.appspot.com/129078/diff/1/3
File appengine-rack/lib/appengine-rack.rb (right):
http://codereview.appspot.com/129078/diff/1/3#newcode125
Line 125: def precompilation_enabled?
On 2009/10/16 16:36:39, ribrdb wrote:
> How about adding an enable_precompilation method too?
ping?