Code review - Issue 12586043: code review 12586043: net: fix small bug introduced by 48f7c4dd87fehttps://codereview.appspot.com/2013-08-07T03:36:51+00:00rietveld
Message from unknown
2013-08-07T03:21:29+00:00brainmanurn:md5:4c0cc2310254a0b9a48629b14639afd4
Message from unknown
2013-08-07T03:21:35+00:00brainmanurn:md5:675973f843b95186f166fda8d45c179f
Message from unknown
2013-08-07T03:31:06+00:00brainmanurn:md5:48f86be6978f69503c6ee89c7314e030
Message from alex.brainman@gmail.com
2013-08-07T03:31:14+00:00brainmanurn:md5:2e6f3d00c9ecc59c56a452bc686cf38c
Hello golang-dev@googlegroups.com (cc: dvyukov@google.com),
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from r@golang.org
2013-08-07T03:34:38+00:00rurn:md5:1862c67de5508641cf11e4c7400957c2
LGTM
Message from dave@cheney.net
2013-08-07T03:34:49+00:00dfcurn:md5:ba12b68d2a9ee68ee8ae823075a3e46a
LGTM. Oops
On 07/08/2013, at 13:31, alex.brainman@gmail.com wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: dvyukov@google.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> net: fix small bug introduced by 48f7c4dd87fe
>
> Fixes issue 6063
>
> Please review this at https://codereview.appspot.com/12586043/
>
> Affected files:
> M src/pkg/net/fd_windows.go
>
>
> Index: src/pkg/net/fd_windows.go
> ===================================================================
> --- a/src/pkg/net/fd_windows.go
> +++ b/src/pkg/net/fd_windows.go
> @@ -257,7 +257,7 @@
> fd.wop.runtimeCtx = fd.pd.runtimeCtx
> if !canCancelIO {
> fd.rop.errc = make(chan error)
> - fd.rop.errc = make(chan error)
> + fd.wop.errc = make(chan error)
> }
> return nil
> }
>
>
> --
>
> ---You received this message because you are subscribed to the Google Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Message from unknown
2013-08-07T03:36:30+00:00brainmanurn:md5:ce0e0ee8a44cce219a51579493e063c0
Message from alex.brainman@gmail.com
2013-08-07T03:36:51+00:00brainmanurn:md5:96fe17bbf9f740aa5b6532b5e32525ab
*** Submitted as https://code.google.com/p/go/source/detail?r=d881cb1ffc14 ***
net: fix small bug introduced by 48f7c4dd87fe
Fixes issue 6063
R=golang-dev, r, dave
CC=dvyukov, golang-dev
https://codereview.appspot.com/12586043