Code review - Issue 110087: New original_tax field in account modulehttps://codereview.appspot.com/2009-08-27T20:40:01+00:00rietveld
Message from unknown
2009-08-26T17:32:26+00:00carlospmurn:md5:c7092fb599b5756b967f50de1d697664
Message from carlos@pemas.es
2009-08-26T17:47:16+00:00carlospmurn:md5:e32e3311eb24531a618df36a6c8387e5
Here you have the patch for the issue http://bugs.tryton.org/roundup/issue1078
It's against current trunk, however, I was only able to test it against 1.2 branch, because for some reason, trunk is not working for me right now (I'm not able to connect with the server, so it's not caused by this patch).
I have a chart of accounts that use it at: http://hg.pemas.es/tryton/account_es_abbreviated/ just in case you want to see it in action.
Cheers
Message from ced@b2ck.com
2009-08-26T20:54:28+00:00ced1urn:md5:23651974750e1c1fb5acfc37a91e90ae
http://codereview.appspot.com/110087/diff/1/2
File tax.py (right):
http://codereview.appspot.com/110087/diff/1/2#newcode955
Line 955: # instead of just the tax group it belongs to.
Put this kind of comment in the help of the field instead.
Message from unknown
2009-08-27T08:18:11+00:00carlospmurn:md5:497e061b511fd1e3bc954e5338726e1c
Message from carlos@pemas.es
2009-08-27T08:19:16+00:00carlospmurn:md5:da7fa8e52f046bcde9e4ebac109e2779
On 2009/08/26 20:54:28, ced wrote:
> http://codereview.appspot.com/110087/diff/1/2
> File tax.py (right):
>
> http://codereview.appspot.com/110087/diff/1/2#newcode955
> Line 955: # instead of just the tax group it belongs to.
> Put this kind of comment in the help of the field instead.
Makes sense, done.
Message from ced@b2ck.com
2009-08-27T08:36:17+00:00ced1urn:md5:4d20d9bbbca7dc0487db1091b70c3774
http://codereview.appspot.com/110087/diff/1005/1006
File tax.py (right):
http://codereview.appspot.com/110087/diff/1005/1006#newcode1004
Line 1004: 'based on it instead of just the tax group it belongs to.'
It must be: "The original tax template"
http://codereview.appspot.com/110087/diff/1005/1006#newcode1102
Line 1102: 'based on it instead of just the tax group it belongs to.'
I find the sentence doesn't explain well the field. Words like "allow us" look strange.
I would say: "If the original tax is filled, the rule will be applied only for this tax"
I think the help must explain the use instead of explaining why the field has been added.
Message from unknown
2009-08-27T09:45:12+00:00carlospmurn:md5:389d3690c489ea0eac2754e409f13214
Message from carlos@pemas.es
2009-08-27T09:45:56+00:00carlospmurn:md5:b0024e988aa94088db9a2d7af4d6bde5
Ok, applied
Message from ced@b2ck.com
2009-08-27T09:52:23+00:00ced1urn:md5:2a68342deb07c04fc3744219beb8f802
Looks good for me you can create the patch
Message from mathias.behrle@gmx.de
2009-08-27T11:14:46+00:00yangoon1urn:md5:d825dc80b4b65f4433d4bb9a9b0731ab
Message from ced@b2ck.com
2009-08-27T20:40:01+00:00ced1urn:md5:7e2ebd40dc3ec3a2ebe2e43b0032b545
can be closed