Code review - Issue 108340043: code review 108340043: cmd/go: do not fail if libgcc does not exist.https://codereview.appspot.com/2022-11-18T17:25:19+00:00rietveld
Message from unknown
2014-07-01T19:16:20+00:00bsiegerturn:md5:5d3011c53758aee726e7ab7035ef73c7
Message from unknown
2014-07-01T19:16:23+00:00bsiegerturn:md5:c88d28bbb469d237880ada04f2d1c1b6
Message from unknown
2014-07-01T19:26:42+00:00bsiegerturn:md5:4692ca60e096576739117da9c30ca90d
Message from bsiegert@gmail.com
2014-07-01T19:26:45+00:00bsiegerturn:md5:b917fd8c8fc340fcf66aebec52e1a1c6
Hello golang-codereviews@googlegroups.com (cc: joerg@netbsd.org),
I'd like you to review this change to
https://code.google.com/p/go/
Message from iant@golang.org
2014-07-02T13:40:50+00:00ianturn:md5:68d7de255d84219afcbbe93184dd1780
Usually the CL description does not have a trailing period. Not that it matters much.
Do we have to worry about a CLA for the pkgsrc sources from which this patch originated?
https://codereview.appspot.com/108340043/diff/40001/src/cmd/go/build.go
File src/cmd/go/build.go (right):
https://codereview.appspot.com/108340043/diff/40001/src/cmd/go/build.go#newcode1953
src/cmd/go/build.go:1953: // clang might not be able to find libgcc, and in that case,
Please update the comment so that it doesn't refer specifically to clang. Just say something like "The compiler might not be able to...."
Message from joerg.sonnenberger@googlemail.com
2014-07-03T13:15:47+00:00joerg.sonnenbergerurn:md5:092543e36719213efcd7771c4f0947c1
On 2014/07/02 13:40:50, iant wrote:
> Do we have to worry about a CLA for the pkgsrc sources from which this patch
> originated?
Not sure if I signed it at some in the past already, but I don't think it is needed for this change.
command update makes sense as it will apply to base gcc on NetBSD at some point in the nearish future too.
Joerg
Message from unknown
2014-07-03T13:16:32+00:00bsiegerturn:md5:8dedf469dc5e60fbbfb1a7d1035d0c74
Message from bsiegert@gmail.com
2014-07-03T13:19:31+00:00bsiegerturn:md5:f6b1cfa50632e3d7925ee5d6c4a7d893
PTAL.
I don't think we need to worry about the CLA. The change is trivial enough as-is, and I actually made that change myself, not by applying the patch. But IANAL.
https://codereview.appspot.com/108340043/diff/40001/src/cmd/go/build.go
File src/cmd/go/build.go (right):
https://codereview.appspot.com/108340043/diff/40001/src/cmd/go/build.go#newcode1953
src/cmd/go/build.go:1953: // clang might not be able to find libgcc, and in that case,
On 2014/07/02 13:40:50, iant wrote:
> Please update the comment so that it doesn't refer specifically to clang. Just
> say something like "The compiler might not be able to...."
Done.
Message from dave@cheney.net
2014-07-09T06:26:11+00:00dfcurn:md5:ffacebc7f34ceccb288e12cf9c785dda
I can't speak to the CLA question, but the change makes sense.
Message from iant@golang.org
2014-07-10T21:31:40+00:00ianturn:md5:1e641783542631643ec834aadaa8e05c
LGTM
Message from iant@golang.org
2014-07-10T21:35:13+00:00ianturn:md5:17d0e0f1642bf42a1eba55fc3b88a2fc
*** Submitted as https://code.google.com/p/go/source/detail?r=5af436a50c54 ***
cmd/go: do not fail if libgcc does not exist
(This is a patch from the pkgsrc Go package.)
LGTM=iant
R=golang-codereviews, iant, joerg.sonnenberger, dave
CC=golang-codereviews, joerg
https://codereview.appspot.com/108340043
Committer: Ian Lance Taylor <iant@golang.org>
Message from gobot@golang.org
2014-07-10T21:41:35+00:00goboturn:md5:e247e00ff2ee841136f63b869ff46588
This CL appears to have broken the android-arm-crawshaw builder.
See http://build.golang.org/log/78a118c4f0787586cccd3e8f1801cbff7215f33c
Message from minux@golang.org
2014-07-10T21:47:45+00:00minuxurn:md5:e3529f608a9ce2322dc38f511a84be1c
On Thu, Jul 10, 2014 at 5:41 PM, <gobot@golang.org> wrote:
> This CL appears to have broken the android-arm-crawshaw builder.
> See http://build.golang.org/log/78a118c4f0787586cccd3e8f1801cbff7215f33c
unrelated.
go_android_exec: adb push /tmp/go-build525474402/net/_test/net.test
/data/local/tmp/goroot/net.test-5629-tmp
160 KB/s (3378452 bytes in 20.531s)
go_android_exec: adb shell cp '/data/local/tmp/goroot/net.test-5629-tmp'
'/data/local/tmp/goroot/net.test-5629'
go_android_exec: adb shell rm '/data/local/tmp/goroot/net.test-5629-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp"; export
GOROOT="/data/local/tmp/goroot"; cd "$GOROOT/src/pkg/net";
'/data/local/tmp/goroot/net.test-5629' -test.short=true -test.timeout=360s;
echo -n exitcode=$?
--- FAIL: TestPacketConn (0.24s)
packetconn_test.go:25: skipping test; must be root
packetconn_test.go:106: PacketConn.WriteTo failed: write unixgram: i/o
timeout
FAIL
exitcode=1go_android_exec: adb shell rm
'/data/local/tmp/goroot/net.test-5629'
FAIL net 62.247s
Message from bargere73@gmail.com
2022-11-18T17:25:13+00:00Ézurn:md5:34940b9bfdecd5bda0f6d8a154e5c236
On 2014/07/03 13:15:47, joerg.sonnenberger wrote:
> On 2014/07/02 13:40:50, iant wrote:
> > Do we have to worry about a CLA for the pkgsrc sources from which this patch
> > originated?
>
> Not sure if I signed it at some in the past already, but I don't think it is
> needed for this change.
> command update makes sense as it will apply to base gcc on NetBSD at some point
> in the nearish future too.
>
> Joerg
<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code Review - All issues</title><link href="https://codereview.appspot.com/" rel="alternate"></link><link href="https://codereview.appspot.com/rss/all" rel="self"></link><id>https://codereview.appspot.com/</id><updated>2022-11-18T17:23:30+00:00</updated><author><name>rietveld</name></author><entry><title>Python: Equality and hashing for functools.partial
</title><link href="https://codereview.appspot.com/1179044/" rel="alternate"></link><updated>2022-11-18T17:23:30+00:00</updated><author><name>DUrban</name></author><id>urn:md5:bc423aba80705df7f2b06bac387fd03d</id><summary type="html">
Python feature request: http://bugs.python.org/issue8699
On python-dev came up an idea [1] to support equality (== and !=) and hashing by functools.partial instances. Van Lindberg provided an implementation written in Python [2]. I&amp;#39;ve made a very similar implementation in C (in Modules/_functoolsmodule.c). The Python equivalent of my code is in Lib/test/test_functools.py as the PythonPartialCls class. The hashing differs a little from Van Lindberg&amp;#39;s implementation: I&amp;#39;m computing the &amp;quot;normal form&amp;quot; of the dict as the sorted list of its items (not as the sorted list of the keys followed by the items). (It was easier to implement this way.)
I haven&amp;#39;t made a lot of Python programming in C, so I&amp;#39;m not sure I made everything in the right way (especially the reference counting). I&amp;#39;d appreciate every suggestion, and will try to correct my mistakes.
Thanks!
[1] http://mail.python.org/pipermail/python-dev/2010-May/099981.html
[2] http://mail.python.org/pipermail/python-dev/2010-May/099996.html
</summary></entry><entry><title>remotize kit initial code review
</title><link href="https://codereview.appspot.com/5504046/" rel="alternate"></link><updated>2022-11-18T14:57:43+00:00</updated><author><name>josvazg</name></author><id>urn:md5:b67355c7b7f7830b6cf51f37dd598a35</id><summary type="html">
(No description)
</summary></entry><entry><title>Make EXCEPTION tryjob bubbles purple
</title><link href="https://codereview.appspot.com/137060045/" rel="alternate"></link><updated>2022-09-19T01:02:05+00:00</updated><author><name>phajdan.jr</name></author><id>urn:md5:a11768b9c7f0f895d78b15c5d7b518eb</id><summary type="html">
Make EXCEPTION tryjob bubbles purple
</summary></entry><entry><title>code review 3268042: sync: small naming fix for armv5
</title><link href="https://codereview.appspot.com/3268042/" rel="alternate"></link><updated>2022-08-19T11:42:11+00:00</updated><author><name>dpx</name></author><id>urn:md5:4df0bdc686ced731a8909871beb8261b</id><summary type="html">
sync: small naming fix for armv5
</summary></entry><entry><title>code review 2258044: go_spec: composite literals are addressable
</title><link href="https://codereview.appspot.com/2258044/" rel="alternate"></link><updated>2022-07-29T23:32:46+00:00</updated><author><name>stephenm</name></author><id>urn:md5:6e30210c038088a40ad80c8aab46512b</id><summary type="html">
go_spec: composite literals are addressable
</summary></entry><entry><title>Test code review post
</title><link href="https://codereview.appspot.com/6493067/" rel="alternate"></link><updated>2022-06-07T18:11:12+00:00</updated><author><name>ItzmE29</name></author><id>urn:md5:97932c56597ba525fb046fe6a73414f3</id><summary type="html">
This is a test review code post
</summary></entry><entry><title>Support for detection of doublequote property in csv.Sniff
</title><link href="https://codereview.appspot.com/96202/" rel="alternate"></link><updated>2022-05-21T20:31:56+00:00</updated><author><name>twb</name></author><id>urn:md5:0018dcb62d355f239a0904b54b665a4a</id><summary type="html">
(No description)
</summary></entry><entry><title>splitPane handle shouldn&amp;#39;t use a higher z-index
</title><link href="https://codereview.appspot.com/1683047/" rel="alternate"></link><updated>2022-05-16T00:01:50+00:00</updated><author><name>canuda10</name></author><id>urn:md5:93267b334738cdfd18a9167570d19ff0</id><summary type="html">
splitPane&amp;#39;s handle uses a zIndex of 2 to be on top of the iframe. That causes the handle to hover over other elements. As the iframe is hidden (with z-index -1) when not dragging the handle, the handle z-index can revert to default (0) when not dragging and hover only while dragging, which solves the problem of having two dialogs with a splitPane in them.
</summary></entry><entry><title>Fix goog.style.getBoundingClientRect_ for SVG documents in IE
</title><link href="https://codereview.appspot.com/7528045/" rel="alternate"></link><updated>2022-05-15T06:22:55+00:00</updated><author><name>paroga</name></author><id>urn:md5:1e6a5d7ac052a39fb673885a820be711</id><summary type="html">
The SVG document has no body attribute.
Do not access it if it is not available.
</summary></entry><entry><title>Suggested goog.editor focus patch
</title><link href="https://codereview.appspot.com/8936044/" rel="alternate"></link><updated>2022-05-15T06:22:08+00:00</updated><author><name>matijasss</name></author><id>urn:md5:c37c6be4e3757a3b991c29cddf76d69d</id><summary type="html">
If you select a format button in the Toolbar without focusing the editor it will not work.
I am proposing a patch that will focus the field after excecuting an tolbar command.
In the same file I added a fix for IOS where the focus function is not working.
Cheers
Matija
</summary></entry><entry><title>Cancel button in music library - issue 647
</title><link href="https://codereview.appspot.com/5647044/" rel="alternate"></link><updated>2022-05-15T06:16:53+00:00</updated><author><name>vasilakisfil</name></author><id>urn:md5:68042df3e5eb2d11684fd2e849148da9</id><summary type="html">
Cancel button in music library - issue 647
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639051/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:bcfbf904929afbdbad15e511337e50f6</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4644054/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:b2395a6f5c80c161e90ba527f5e8f275</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4643049/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:a79ab3c5f0d3c1b92bc71db2ac587e69</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4633055/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:f01fe67aaae1102c06fde732ecc812b9</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639058/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:8421b7bbb9a138d9300738618d9afa3a</id><summary type="html">
(No description)
</summary></entry><entry><title>test1
</title><link href="https://codereview.appspot.com/4634072/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:924c725f9841fb18580c1e5a0bee569b</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4664044/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:4cfdab500bd21550c4dde0224716f2c1</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4630064/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:3c51e2f7a368fbde827c11ce52cc7b29</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4626084/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:6e231fa542b047496eab3aa82344a210</id><summary type="html">
(No description)
</summary></entry></feed>
Message from bargere73@gmail.com
2022-11-18T17:25:17+00:00Ézurn:md5:14f9bddf0535cc6ecb04124baff4e089
On 2014/07/03 13:15:47, joerg.sonnenberger wrote:
> On 2014/07/02 13:40:50, iant wrote:
> > Do we have to worry about a CLA for the pkgsrc sources from which this patch
> > originated?
>
> Not sure if I signed it at some in the past already, but I don't think it is
> needed for this change.
> command update makes sense as it will apply to base gcc on NetBSD at some point
> in the nearish future too.
>
> Joerg
<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code Review - All issues</title><link href="https://codereview.appspot.com/" rel="alternate"></link><link href="https://codereview.appspot.com/rss/all" rel="self"></link><id>https://codereview.appspot.com/</id><updated>2022-11-18T17:23:30+00:00</updated><author><name>rietveld</name></author><entry><title>Python: Equality and hashing for functools.partial
</title><link href="https://codereview.appspot.com/1179044/" rel="alternate"></link><updated>2022-11-18T17:23:30+00:00</updated><author><name>DUrban</name></author><id>urn:md5:bc423aba80705df7f2b06bac387fd03d</id><summary type="html">
Python feature request: http://bugs.python.org/issue8699
On python-dev came up an idea [1] to support equality (== and !=) and hashing by functools.partial instances. Van Lindberg provided an implementation written in Python [2]. I&amp;#39;ve made a very similar implementation in C (in Modules/_functoolsmodule.c). The Python equivalent of my code is in Lib/test/test_functools.py as the PythonPartialCls class. The hashing differs a little from Van Lindberg&amp;#39;s implementation: I&amp;#39;m computing the &amp;quot;normal form&amp;quot; of the dict as the sorted list of its items (not as the sorted list of the keys followed by the items). (It was easier to implement this way.)
I haven&amp;#39;t made a lot of Python programming in C, so I&amp;#39;m not sure I made everything in the right way (especially the reference counting). I&amp;#39;d appreciate every suggestion, and will try to correct my mistakes.
Thanks!
[1] http://mail.python.org/pipermail/python-dev/2010-May/099981.html
[2] http://mail.python.org/pipermail/python-dev/2010-May/099996.html
</summary></entry><entry><title>remotize kit initial code review
</title><link href="https://codereview.appspot.com/5504046/" rel="alternate"></link><updated>2022-11-18T14:57:43+00:00</updated><author><name>josvazg</name></author><id>urn:md5:b67355c7b7f7830b6cf51f37dd598a35</id><summary type="html">
(No description)
</summary></entry><entry><title>Make EXCEPTION tryjob bubbles purple
</title><link href="https://codereview.appspot.com/137060045/" rel="alternate"></link><updated>2022-09-19T01:02:05+00:00</updated><author><name>phajdan.jr</name></author><id>urn:md5:a11768b9c7f0f895d78b15c5d7b518eb</id><summary type="html">
Make EXCEPTION tryjob bubbles purple
</summary></entry><entry><title>code review 3268042: sync: small naming fix for armv5
</title><link href="https://codereview.appspot.com/3268042/" rel="alternate"></link><updated>2022-08-19T11:42:11+00:00</updated><author><name>dpx</name></author><id>urn:md5:4df0bdc686ced731a8909871beb8261b</id><summary type="html">
sync: small naming fix for armv5
</summary></entry><entry><title>code review 2258044: go_spec: composite literals are addressable
</title><link href="https://codereview.appspot.com/2258044/" rel="alternate"></link><updated>2022-07-29T23:32:46+00:00</updated><author><name>stephenm</name></author><id>urn:md5:6e30210c038088a40ad80c8aab46512b</id><summary type="html">
go_spec: composite literals are addressable
</summary></entry><entry><title>Test code review post
</title><link href="https://codereview.appspot.com/6493067/" rel="alternate"></link><updated>2022-06-07T18:11:12+00:00</updated><author><name>ItzmE29</name></author><id>urn:md5:97932c56597ba525fb046fe6a73414f3</id><summary type="html">
This is a test review code post
</summary></entry><entry><title>Support for detection of doublequote property in csv.Sniff
</title><link href="https://codereview.appspot.com/96202/" rel="alternate"></link><updated>2022-05-21T20:31:56+00:00</updated><author><name>twb</name></author><id>urn:md5:0018dcb62d355f239a0904b54b665a4a</id><summary type="html">
(No description)
</summary></entry><entry><title>splitPane handle shouldn&amp;#39;t use a higher z-index
</title><link href="https://codereview.appspot.com/1683047/" rel="alternate"></link><updated>2022-05-16T00:01:50+00:00</updated><author><name>canuda10</name></author><id>urn:md5:93267b334738cdfd18a9167570d19ff0</id><summary type="html">
splitPane&amp;#39;s handle uses a zIndex of 2 to be on top of the iframe. That causes the handle to hover over other elements. As the iframe is hidden (with z-index -1) when not dragging the handle, the handle z-index can revert to default (0) when not dragging and hover only while dragging, which solves the problem of having two dialogs with a splitPane in them.
</summary></entry><entry><title>Fix goog.style.getBoundingClientRect_ for SVG documents in IE
</title><link href="https://codereview.appspot.com/7528045/" rel="alternate"></link><updated>2022-05-15T06:22:55+00:00</updated><author><name>paroga</name></author><id>urn:md5:1e6a5d7ac052a39fb673885a820be711</id><summary type="html">
The SVG document has no body attribute.
Do not access it if it is not available.
</summary></entry><entry><title>Suggested goog.editor focus patch
</title><link href="https://codereview.appspot.com/8936044/" rel="alternate"></link><updated>2022-05-15T06:22:08+00:00</updated><author><name>matijasss</name></author><id>urn:md5:c37c6be4e3757a3b991c29cddf76d69d</id><summary type="html">
If you select a format button in the Toolbar without focusing the editor it will not work.
I am proposing a patch that will focus the field after excecuting an tolbar command.
In the same file I added a fix for IOS where the focus function is not working.
Cheers
Matija
</summary></entry><entry><title>Cancel button in music library - issue 647
</title><link href="https://codereview.appspot.com/5647044/" rel="alternate"></link><updated>2022-05-15T06:16:53+00:00</updated><author><name>vasilakisfil</name></author><id>urn:md5:68042df3e5eb2d11684fd2e849148da9</id><summary type="html">
Cancel button in music library - issue 647
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639051/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:bcfbf904929afbdbad15e511337e50f6</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4644054/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:b2395a6f5c80c161e90ba527f5e8f275</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4643049/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:a79ab3c5f0d3c1b92bc71db2ac587e69</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4633055/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:f01fe67aaae1102c06fde732ecc812b9</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639058/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:8421b7bbb9a138d9300738618d9afa3a</id><summary type="html">
(No description)
</summary></entry><entry><title>test1
</title><link href="https://codereview.appspot.com/4634072/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:924c725f9841fb18580c1e5a0bee569b</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4664044/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:4cfdab500bd21550c4dde0224716f2c1</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4630064/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:3c51e2f7a368fbde827c11ce52cc7b29</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4626084/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:6e231fa542b047496eab3aa82344a210</id><summary type="html">
(No description)
</summary></entry></feed>
Message from bargere73@gmail.com
2022-11-18T17:25:19+00:00Ézurn:md5:0d254c0e52ed7fb859eb6d2ee7a3efdf
On 2014/07/03 13:15:47, joerg.sonnenberger wrote:
> On 2014/07/02 13:40:50, iant wrote:
> > Do we have to worry about a CLA for the pkgsrc sources from which this patch
> > originated?
>
> Not sure if I signed it at some in the past already, but I don't think it is
> needed for this change.
> command update makes sense as it will apply to base gcc on NetBSD at some point
> in the nearish future too.
>
> Joerg
<?xml version="1.0" encoding="utf-8"?>
<feed xmlns="http://www.w3.org/2005/Atom" xml:lang="en-us"><title>Code Review - All issues</title><link href="https://codereview.appspot.com/" rel="alternate"></link><link href="https://codereview.appspot.com/rss/all" rel="self"></link><id>https://codereview.appspot.com/</id><updated>2022-11-18T17:23:30+00:00</updated><author><name>rietveld</name></author><entry><title>Python: Equality and hashing for functools.partial
</title><link href="https://codereview.appspot.com/1179044/" rel="alternate"></link><updated>2022-11-18T17:23:30+00:00</updated><author><name>DUrban</name></author><id>urn:md5:bc423aba80705df7f2b06bac387fd03d</id><summary type="html">
Python feature request: http://bugs.python.org/issue8699
On python-dev came up an idea [1] to support equality (== and !=) and hashing by functools.partial instances. Van Lindberg provided an implementation written in Python [2]. I&amp;#39;ve made a very similar implementation in C (in Modules/_functoolsmodule.c). The Python equivalent of my code is in Lib/test/test_functools.py as the PythonPartialCls class. The hashing differs a little from Van Lindberg&amp;#39;s implementation: I&amp;#39;m computing the &amp;quot;normal form&amp;quot; of the dict as the sorted list of its items (not as the sorted list of the keys followed by the items). (It was easier to implement this way.)
I haven&amp;#39;t made a lot of Python programming in C, so I&amp;#39;m not sure I made everything in the right way (especially the reference counting). I&amp;#39;d appreciate every suggestion, and will try to correct my mistakes.
Thanks!
[1] http://mail.python.org/pipermail/python-dev/2010-May/099981.html
[2] http://mail.python.org/pipermail/python-dev/2010-May/099996.html
</summary></entry><entry><title>remotize kit initial code review
</title><link href="https://codereview.appspot.com/5504046/" rel="alternate"></link><updated>2022-11-18T14:57:43+00:00</updated><author><name>josvazg</name></author><id>urn:md5:b67355c7b7f7830b6cf51f37dd598a35</id><summary type="html">
(No description)
</summary></entry><entry><title>Make EXCEPTION tryjob bubbles purple
</title><link href="https://codereview.appspot.com/137060045/" rel="alternate"></link><updated>2022-09-19T01:02:05+00:00</updated><author><name>phajdan.jr</name></author><id>urn:md5:a11768b9c7f0f895d78b15c5d7b518eb</id><summary type="html">
Make EXCEPTION tryjob bubbles purple
</summary></entry><entry><title>code review 3268042: sync: small naming fix for armv5
</title><link href="https://codereview.appspot.com/3268042/" rel="alternate"></link><updated>2022-08-19T11:42:11+00:00</updated><author><name>dpx</name></author><id>urn:md5:4df0bdc686ced731a8909871beb8261b</id><summary type="html">
sync: small naming fix for armv5
</summary></entry><entry><title>code review 2258044: go_spec: composite literals are addressable
</title><link href="https://codereview.appspot.com/2258044/" rel="alternate"></link><updated>2022-07-29T23:32:46+00:00</updated><author><name>stephenm</name></author><id>urn:md5:6e30210c038088a40ad80c8aab46512b</id><summary type="html">
go_spec: composite literals are addressable
</summary></entry><entry><title>Test code review post
</title><link href="https://codereview.appspot.com/6493067/" rel="alternate"></link><updated>2022-06-07T18:11:12+00:00</updated><author><name>ItzmE29</name></author><id>urn:md5:97932c56597ba525fb046fe6a73414f3</id><summary type="html">
This is a test review code post
</summary></entry><entry><title>Support for detection of doublequote property in csv.Sniff
</title><link href="https://codereview.appspot.com/96202/" rel="alternate"></link><updated>2022-05-21T20:31:56+00:00</updated><author><name>twb</name></author><id>urn:md5:0018dcb62d355f239a0904b54b665a4a</id><summary type="html">
(No description)
</summary></entry><entry><title>splitPane handle shouldn&amp;#39;t use a higher z-index
</title><link href="https://codereview.appspot.com/1683047/" rel="alternate"></link><updated>2022-05-16T00:01:50+00:00</updated><author><name>canuda10</name></author><id>urn:md5:93267b334738cdfd18a9167570d19ff0</id><summary type="html">
splitPane&amp;#39;s handle uses a zIndex of 2 to be on top of the iframe. That causes the handle to hover over other elements. As the iframe is hidden (with z-index -1) when not dragging the handle, the handle z-index can revert to default (0) when not dragging and hover only while dragging, which solves the problem of having two dialogs with a splitPane in them.
</summary></entry><entry><title>Fix goog.style.getBoundingClientRect_ for SVG documents in IE
</title><link href="https://codereview.appspot.com/7528045/" rel="alternate"></link><updated>2022-05-15T06:22:55+00:00</updated><author><name>paroga</name></author><id>urn:md5:1e6a5d7ac052a39fb673885a820be711</id><summary type="html">
The SVG document has no body attribute.
Do not access it if it is not available.
</summary></entry><entry><title>Suggested goog.editor focus patch
</title><link href="https://codereview.appspot.com/8936044/" rel="alternate"></link><updated>2022-05-15T06:22:08+00:00</updated><author><name>matijasss</name></author><id>urn:md5:c37c6be4e3757a3b991c29cddf76d69d</id><summary type="html">
If you select a format button in the Toolbar without focusing the editor it will not work.
I am proposing a patch that will focus the field after excecuting an tolbar command.
In the same file I added a fix for IOS where the focus function is not working.
Cheers
Matija
</summary></entry><entry><title>Cancel button in music library - issue 647
</title><link href="https://codereview.appspot.com/5647044/" rel="alternate"></link><updated>2022-05-15T06:16:53+00:00</updated><author><name>vasilakisfil</name></author><id>urn:md5:68042df3e5eb2d11684fd2e849148da9</id><summary type="html">
Cancel button in music library - issue 647
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639051/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:bcfbf904929afbdbad15e511337e50f6</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4644054/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:b2395a6f5c80c161e90ba527f5e8f275</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4643049/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:a79ab3c5f0d3c1b92bc71db2ac587e69</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4633055/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:f01fe67aaae1102c06fde732ecc812b9</id><summary type="html">
(No description)
</summary></entry><entry><title>test
</title><link href="https://codereview.appspot.com/4639058/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:8421b7bbb9a138d9300738618d9afa3a</id><summary type="html">
(No description)
</summary></entry><entry><title>test1
</title><link href="https://codereview.appspot.com/4634072/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:924c725f9841fb18580c1e5a0bee569b</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4664044/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:4cfdab500bd21550c4dde0224716f2c1</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4630064/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:3c51e2f7a368fbde827c11ce52cc7b29</id><summary type="html">
(No description)
</summary></entry><entry><title>ttt
</title><link href="https://codereview.appspot.com/4626084/" rel="alternate"></link><updated>2022-04-05T09:36:12+00:00</updated><author><name>swc4848a</name></author><id>urn:md5:6e231fa542b047496eab3aa82344a210</id><summary type="html">
(No description)
</summary></entry></feed>