Code review - Issue 10485043: code review 10485043: runtime: change netpoll in preparation for windows impl...https://codereview.appspot.com/2013-06-25T02:29:09+00:00rietveld
Message from unknown
2013-06-24T04:32:28+00:00brainmanurn:md5:e55e0cfaa6252911af6d553b93911d61
Message from unknown
2013-06-24T04:32:35+00:00brainmanurn:md5:0a7ce73d079c2574a4dd7d8bb2a44984
Message from unknown
2013-06-24T04:39:02+00:00brainmanurn:md5:a7a861ecb468f52af5465a8371ae8321
Message from alex.brainman@gmail.com
2013-06-24T04:39:12+00:00brainmanurn:md5:0159ed2e3b14daf87a6ac93a18ff4ab2
Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/
Message from dvyukov@google.com
2013-06-24T09:16:36+00:00dvyukovurn:md5:8e79e2342c19bfb7471e1dec9a6ad516
LGTM
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc
File src/pkg/runtime/netpoll.goc (right):
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc#newcode273
src/pkg/runtime/netpoll.goc:273: if(*gpp == READY) {
drop {}
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc#newcode288
src/pkg/runtime/netpoll.goc:288: old->param = 0;
this should be nil
probably just old->param = (void*)ioready;
Message from unknown
2013-06-25T02:28:51+00:00brainmanurn:md5:eb6496d7733c756c23787608f4134d1f
Message from alex.brainman@gmail.com
2013-06-25T02:29:09+00:00brainmanurn:md5:b4441107a0aeab83a48d616534541d37
*** Submitted as https://code.google.com/p/go/source/detail?r=8de6d4c58935 ***
runtime: change netpoll in preparation for windows implementation
- change runtime_pollWait so it does not return
closed or timeout if IO is ready - windows must
know if IO has completed or not even after
interruption;
- add (*pollDesc).Prepare(mode int) that can be
used for both read and write, same for Wait;
- introduce runtime_pollWaitCanceled and expose
it in net as (*pollDesc).WaitCanceled(mode int);
Full windows netpoll changes are
here https://codereview.appspot.com/8670044/.
R=golang-dev, dvyukov
CC=golang-dev
https://codereview.appspot.com/10485043
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc
File src/pkg/runtime/netpoll.goc (right):
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc#newcode273
src/pkg/runtime/netpoll.goc:273: if(*gpp == READY) {
On 2013/06/24 09:16:36, dvyukov wrote:
> drop {}
Done.
https://codereview.appspot.com/10485043/diff/5001/src/pkg/runtime/netpoll.goc#newcode288
src/pkg/runtime/netpoll.goc:288: old->param = 0;
On 2013/06/24 09:16:36, dvyukov wrote:
> this should be nil
> probably just old->param = (void*)ioready;
Done.