Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1109)

Issue 9922043: code review 9922043: go.crypto/ssh: add hook for host key checking. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by hanwen-google
Modified:
10 years, 8 months ago
Reviewers:
dfc
CC:
dfc, agl1, gobot, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: add hook for host key checking.

Patch Set 1 #

Patch Set 2 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 273987d8ccbc https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 4 : diff -r c510c3e5067d https://code.google.com/p/go.crypto #

Total comments: 6

Patch Set 5 : diff -r c510c3e5067d https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 6 : diff -r c510c3e5067d https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r c510c3e5067d https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r c510c3e5067d https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 9 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Patch Set 10 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Patch Set 11 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Patch Set 12 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 13 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Total comments: 2

Patch Set 14 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Patch Set 15 : diff -r d73471ad7bea https://code.google.com/p/go.crypto #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -6 lines) Patch
M ssh/client.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +28 lines, -1 line 1 comment Download
M ssh/client_auth.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +12 lines, -0 lines 0 comments Download
M ssh/test/session_test.go View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ssh/test/test_unix_test.go View 1 2 3 4 5 6 7 8 9 10 11 12 13 4 chunks +46 lines, -5 lines 1 comment Download

Messages

Total messages: 26
hanwen-google
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
10 years, 10 months ago (2013-05-31 22:22:24 UTC) #1
gobot
R=dfc (assigned by dfc)
10 years, 10 months ago (2013-06-01 02:07:04 UTC) #2
hanwen-google
Adam, you may want to look at this too. I was wondering about the location ...
10 years, 9 months ago (2013-06-06 14:47:31 UTC) #3
agl1
https://codereview.appspot.com/9922043/diff/9002/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/9002/ssh/client.go#newcode192 ssh/client.go:192: checker := c.config.HostKeyChecker I don't think it matters from ...
10 years, 9 months ago (2013-06-07 16:06:55 UTC) #4
hanwen-google
https://codereview.appspot.com/9922043/diff/9002/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/9002/ssh/client.go#newcode192 ssh/client.go:192: checker := c.config.HostKeyChecker On 2013/06/07 16:06:55, agl1 wrote: > ...
10 years, 9 months ago (2013-06-07 16:51:54 UTC) #5
hanwen-google
On Fri, Jun 7, 2013 at 6:51 PM, <hanwen@google.com> wrote: >> to connect to a, ...
10 years, 9 months ago (2013-06-08 10:26:02 UTC) #6
dfc
Some small comments. Sorry I haven't had time for a full review. https://codereview.appspot.com/9922043/diff/3001/ssh/client.go File ssh/client.go ...
10 years, 9 months ago (2013-06-10 01:15:06 UTC) #7
hanwen-google
I've changed the checker function so it takes both string address and the net.Addr https://codereview.appspot.com/9922043/diff/3001/ssh/client.go ...
10 years, 9 months ago (2013-06-10 17:12:38 UTC) #8
dfc
https://codereview.appspot.com/9922043/diff/23001/ssh/test/test_unix_test.go File ssh/test/test_unix_test.go (left): https://codereview.appspot.com/9922043/diff/23001/ssh/test/test_unix_test.go#oldcode168 ssh/test/test_unix_test.go:168: // from that that package provide. why has all ...
10 years, 9 months ago (2013-06-11 10:52:30 UTC) #9
dfc
On 2013/06/10 17:12:38, hanwen wrote: > I've changed the checker function so it takes both ...
10 years, 9 months ago (2013-06-11 10:55:38 UTC) #10
hanwen-google
On Tue, Jun 11, 2013 at 12:55 PM, <dave@cheney.net> wrote: >> Is it assumed that ...
10 years, 9 months ago (2013-06-11 12:24:35 UTC) #11
dfc
> Fair enough; I didn't realize that. I'll have another look at this > from ...
10 years, 9 months ago (2013-06-11 12:56:50 UTC) #12
hanwen-google
PTAL moved the unresolved address into Config, and fixed the merge snafu. https://codereview.appspot.com/9922043/diff/23001/ssh/test/test_unix_test.go File ssh/test/test_unix_test.go ...
10 years, 9 months ago (2013-06-11 13:44:12 UTC) #13
dfc
https://codereview.appspot.com/9922043/diff/42001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/42001/ssh/client.go#newcode475 ssh/client.go:475: DialAddress string I'm sorry, one last thing. The form ...
10 years, 9 months ago (2013-06-11 14:14:49 UTC) #14
hanwen-google
https://codereview.appspot.com/9922043/diff/42001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/42001/ssh/client.go#newcode475 ssh/client.go:475: DialAddress string On 2013/06/11 14:14:49, dfc wrote: > I'm ...
10 years, 9 months ago (2013-06-11 15:02:53 UTC) #15
dfc
My main concern is this change does not break existing code. ie, if there is ...
10 years, 9 months ago (2013-06-12 02:28:02 UTC) #16
hanwen-google
The default is a nil HostKeyChecker, which is equivalent to what we have today. On ...
10 years, 9 months ago (2013-06-12 09:09:34 UTC) #17
dfc
LGTM in that case. On Wed, Jun 12, 2013 at 7:09 PM, Han-Wen Nienhuys <hanwen@google.com> ...
10 years, 9 months ago (2013-06-12 09:20:21 UTC) #18
agl1
https://codereview.appspot.com/9922043/diff/48001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/48001/ssh/client.go#newcode444 ssh/client.go:444: config.DialAddress = addr The config argument cannot be mutated ...
10 years, 9 months ago (2013-06-14 19:32:02 UTC) #19
hanwen-google
https://codereview.appspot.com/9922043/diff/48001/ssh/client.go File ssh/client.go (right): https://codereview.appspot.com/9922043/diff/48001/ssh/client.go#newcode444 ssh/client.go:444: config.DialAddress = addr On 2013/06/14 19:32:03, agl1 wrote: > ...
10 years, 9 months ago (2013-06-17 13:05:03 UTC) #20
hanwen-google
PTAL reverted to storing the dial address separately.
10 years, 9 months ago (2013-06-18 13:01:09 UTC) #21
hanwen-google
friendly ping? On Tue, Jun 18, 2013 at 3:01 PM, <hanwen@google.com> wrote: > PTAL > ...
10 years, 9 months ago (2013-06-20 11:21:23 UTC) #22
agl1
I really planned to get to this today, honest. It's not quite ready to land, ...
10 years, 9 months ago (2013-06-20 22:26:11 UTC) #23
agl1
Note: I'll make these changes before landing in order to avoid delaying this any further. ...
10 years, 9 months ago (2013-06-21 16:46:02 UTC) #24
agl1
*** Submitted as https://code.google.com/p/go/source/detail?r=5f8544e29ba7&repo=crypto *** go.crypto/ssh: add hook for host key checking. R=dave, agl CC=gobot, ...
10 years, 9 months ago (2013-06-21 16:46:54 UTC) #25
hanwen-google
10 years, 8 months ago (2013-07-23 10:13:19 UTC) #26
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b