Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(278)

Issue 9894043: Fixes problem with -dpreview cropping staff brackets (Issue 3386) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by PhilEHolmes
Modified:
10 years, 10 months ago
Reviewers:
Keith, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

This is a simple revert of the problematic lines in the original commit - I've not done any study as to why these are the problem, but this change makes -dpreview function as it should once again when there are braces and brackets present. I've pixel-compared and the only change is a very minor shift in the bar number on beam-broken-difficult.ly

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M scm/define-grobs.scm View 4 chunks +0 lines, -4 lines 1 comment Download

Messages

Total messages: 3
PhilEHolmes
Please review.
10 years, 11 months ago (2013-05-31 12:29:46 UTC) #1
dak
On 2013/05/31 12:29:46, PhilEHolmes wrote: > Please review. Color me surprised. Patch set 3 from ...
10 years, 11 months ago (2013-05-31 12:54:51 UTC) #2
Keith
10 years, 10 months ago (2013-06-06 03:29:16 UTC) #3
>  Patch set 3 from the original patch is

not relevant.  In the previous round of that review I had suggested marking the
start brace as 'cross-staff' which generally means "my size/position/shape is
not final until staves are spaced on the page".  Unfortunately I forgot that
'cross-staff' has the side effect or "leave me out of EPS extents" which has
been a problem for years.

Without the 'cross-staff' indication, we need to explicitly say to estimate the
horizontal extent of the staff-brace, and similar items, before its stencil is
finalized.

https://codereview.appspot.com/9894043/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

https://codereview.appspot.com/9894043/diff/1/scm/define-grobs.scm#newcode2252
scm/define-grobs.scm:2252: 
(horizontal-skylines . ,grob::simple-horizontal-skylines-from-x-extent)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b