Issue 98630044: Make the win version match the go version.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98630044: Make the win version match the go version.

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by curtis

Modified:
9 years, 11 months ago

Reviewers:
mp+221133, hduran

Visibility:
Public.

Description

Make the win version match the go version. The juju version was updated without also updating the win intaller rules; The win installer was broken. https://code.launchpad.net/~sinzui/juju-core/fix-mismatech-win-version/+merge/221133 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	scripts/win-installer/setup.iss	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

curtis

self LGTM to fix botched version change to address windows installer regression.

9 years, 11 months ago (2014-05-27 18:28:06 UTC) #2

hduran

9 years, 11 months ago (2014-05-27 18:52:14 UTC) #3

On 2014/05/27 18:28:06, curtis wrote:
> self LGTM to fix botched version change to address windows installer
regression.

LGTM

Expand All Messages | Collapse All Messages