Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(148)

Issue 986041: ns-3: Bring rate representation in line with IEEE 802.11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by Dean
Modified:
11 years ago
Reviewers:
Nicola Baldo, Mathieu Lacage, nbaldo
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

This patch attempts to lay some groundwork for enhancements to the Wi-Fi module by bringing the representation of transmit rates more in line with the standard. The patch is based on ns-3-dev changeset 6266:35e7d9d585be, and is proposed as part of a fix for Bug 871 in the ns-3 Bugzilla module. The key part of the patch is the introduction of a type that corresponds to the notion of Modulation Class described in IEEE 802.11-2007, Section 9.6.1, Table 9-2. It also adds coding rate information to the WifiModes and centralises their construction into a single WifiModeFactory method. The rates are also renamed with reference to the part of the standard that defines them. WifiModes no longer have a WifiStandard, but the latter type still exists and is used to imply the set of WifiModes that a MAC/PHY pair will support.

Patch Set 1 #

Total comments: 17

Patch Set 2 : Second draft of patch, updated based on review comments #

Patch Set 3 : Third draft of patch: reinstate Invalid-WifiMode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+880 lines, -853 lines) Patch
M examples/routing/aodv.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/routing/olsr-hna.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/tap/tap-wifi-virtual-machine.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/tap/tap-wifi-virtual-machine.py View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/mixed-wireless.cc View 1 1 chunk +1 line, -1 line 0 comments Download
examples/wireless/mixed-wireless.py View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-adhoc.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M examples/wireless/wifi-clear-channel-cmu.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M examples/wireless/wifi-hidden-terminal.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-simple-adhoc.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-simple-adhoc-grid.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-simple-infra.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M examples/wireless/wifi-simple-interference.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/devices/wifi/constant-rate-wifi-manager.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/devices/wifi/interference-helper.cc View 1 5 chunks +104 lines, -106 lines 0 comments Download
M src/devices/wifi/interference-helper-tx-duration-test.cc View 1 1 chunk +45 lines, -45 lines 0 comments Download
src/devices/wifi/wifi-mode.h View 1 6 chunks +71 lines, -117 lines 0 comments Download
src/devices/wifi/wifi-mode.cc View 1 2 7 chunks +82 lines, -132 lines 0 comments Download
M src/devices/wifi/wifi-phy.h View 1 1 chunk +34 lines, -28 lines 0 comments Download
M src/devices/wifi/wifi-phy.cc View 1 3 chunks +327 lines, -227 lines 0 comments Download
M src/devices/wifi/wifi-phy-test.cc View 1 3 chunks +11 lines, -11 lines 0 comments Download
M src/devices/wifi/wifi-remote-station-manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
src/devices/wifi/yans-error-rate-model.cc View 1 chunk +117 lines, -104 lines 0 comments Download
M src/devices/wifi/yans-wifi-phy.cc View 1 7 chunks +55 lines, -49 lines 0 comments Download
M src/routing/aodv/test/aodv-regression.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/routing/aodv/test/bug-772.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/routing/aodv/test/loopback.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/routing/olsr/test/bug780-test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/routing/olsr/test/tc-regression-test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/test/ns3wifi/wifi-interference-test-suite.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/test/ns3wifi/wifi-msdu-aggregator-test-suite.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
Mathieu Lacage
my initial reaction was that this patch did too many things at the same time: ...
11 years, 1 month ago (2010-05-19 06:57:11 UTC) #1
Nicola Baldo
Dean, thank you very much for your effort in trying to address this issue. I ...
11 years, 1 month ago (2010-05-21 17:43:51 UTC) #2
Dean
Mathieu, Nicola, Thanks for your comments. Mathieu, I'll endeavour to present smaller coherent pieces of ...
11 years, 1 month ago (2010-05-22 09:00:11 UTC) #3
Mathieu Lacage
On Sat, May 22, 2010 at 11:00 AM, <deanarm@gmail.com> wrote: > I'll endeavour to present ...
11 years, 1 month ago (2010-05-22 18:23:23 UTC) #4
Nicola Baldo
Hi Dean, thank you for your reply. Below some further comments... http://codereview.appspot.com/986041/diff/1/18 File src/devices/wifi/wifi-mode.cc (right): ...
11 years ago (2010-05-26 15:38:53 UTC) #5
Nicola Baldo
On 2010/05/22 18:23:23, Mathieu Lacage wrote: > I am fine with the current patch. It ...
11 years ago (2010-05-26 15:52:41 UTC) #6
Mathieu Lacage
On Wed, May 26, 2010 at 5:52 PM, <nicobaldo@gmail.com> wrote: > What I don't know ...
11 years ago (2010-05-26 18:52:15 UTC) #7
Dean
Nicola, Thanks for your review. On 2010/05/26 15:38:53, Nicola Baldo wrote: > http://codereview.appspot.com/986041/diff/1/18#newcode181 > src/devices/wifi/wifi-mode.cc:181: ...
11 years ago (2010-06-03 15:48:19 UTC) #8
Dean
Nicola, Mathieu, All, I've uploaded a new draft patch as Issue 986041 on Code Review. ...
11 years ago (2010-06-03 15:49:39 UTC) #9
Mathieu Lacage
On Thu, Jun 3, 2010 at 5:49 PM, <deanarm@gmail.com> wrote: > 2) I've done away ...
11 years ago (2010-06-04 08:58:46 UTC) #10
Dean
11 years ago (2010-06-04 10:09:43 UTC) #11
On 2010/06/04 08:58:46, Mathieu Lacage wrote:
> On Thu, Jun 3, 2010 at 5:49 PM,  <mailto:deanarm@gmail.com> wrote:
> > 2) I've done away with the WifiMode named "Invalid-WifiMode", ...
[snip]
> > ...Was there a good reason for it being there?
> 
> I don't remember the details but I believe that it was introduced to
> handle the case where you need to initialize a WifiMode variable
> instance which needs to be overriden later and you want to make sure
> that this WifiMode instance is invalid until it is overriden to catch
> the case where you use it before initializing it.

Okay. Thanks for explaining this.

I've reinstated it in the third draft patch on Code Review.

Regards,
Dean.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b