Issue 98580048: Stop logging jenv

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98580048: Stop logging jenv

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by natefinch

Modified:
9 years, 11 months ago

Reviewers:
axw, mp+221288

Visibility:
Public.

Description

Stop logging jenv This fixes bug https://bugs.launchpad.net/juju-core/+bug/1289038 We shouldn't log the jenv, because it often contains sensitive information. https://code.launchpad.net/~natefinch/juju-core/053-nolog-jenv/+merge/221288 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/open.go	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

axw

9 years, 11 months ago (2014-05-29 01:24:45 UTC) #2

On 2014/05/28 20:15:40, nate.finch wrote:
> Please take a look.

(Just echoing my reply to juju-dev)

I think it'd be better just to sanitise the output by using the
EnvironProvider.SecretAttrs method. Then we get to see the .jenv minus secrets,
which may be helpful in debugging.

Also, we log the bootstrap script, and that contains the full bootstrap config.
That needs to be sanitised (or suppressed) as well. See RunConfigureScript,
cloudinit/sshinit/configure.go; perhaps change that to Tracef?

Expand All Messages | Collapse All Messages