Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1757)

Issue 98420046: code review 98420046: spec: specify order of init() calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by gri
Modified:
6 years, 9 months ago
Reviewers:
r, iant
CC:
rsc, iant, r, ken2, golang-codereviews
Visibility:
Public.

Description

spec: specify order of init() calls The spec did not specify the order in which init() functions are called. Specify that they are called in source order since we have now also specified the initialization order of independent variables. While technically a language change, no existing code could have relied on this, so this should not break anything. Per suggestion from rsc.

Patch Set 1 #

Patch Set 2 : diff -r cd23c6e8c798 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M doc/go_spec.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
gri
Hello rsc, iant, r, ken2 (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...
6 years, 9 months ago (2014-05-20 21:29:14 UTC) #1
r
LGTM
6 years, 9 months ago (2014-05-20 23:01:23 UTC) #2
iant
LGTM
6 years, 9 months ago (2014-05-21 00:04:59 UTC) #3
gri
6 years, 9 months ago (2014-05-21 00:46:04 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=9e1652c32289 ***

spec: specify order of init() calls

The spec did not specify the order in which
init() functions are called. Specify that
they are called in source order since we have
now also specified the initialization order
of independent variables.

While technically a language change, no
existing code could have relied on this,
so this should not break anything.

Per suggestion from rsc.

LGTM=r, iant
R=rsc, iant, r, ken
CC=golang-codereviews
https://codereview.appspot.com/98420046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b