Issue 98400043: Update username regex

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98400043: Update username regex

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by waigani

Modified:
9 years, 11 months ago

Reviewers:
mp+220147, menn0

Visibility:
Public.

Description

Update username regex Loosen up the regex to allow '.' and '-'. https://code.launchpad.net/~waigani/juju-core/new_username_regex/+merge/220147 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Update username regex #

Patch Set 3 : Update username regex #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -3 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/user.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	state/user_test.go	View	1 2	2 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

menn0

9 years, 11 months ago (2014-05-20 04:40:59 UTC) #4

LGTM.

There's still more work for this isn't there? (checking that everything is using
the single way for checking for valid user names)

Expand All Messages | Collapse All Messages