Issue 9827045: TRIVIAL: Revert notifications panel CSS problem.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9827045: TRIVIAL: Revert notifications panel CSS problem.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by bac

Modified:
10 years, 11 months ago

Reviewers:
mp+166130

Visibility:
Public.

Description

TRIVIAL: Revert notifications panel CSS problem. A fix to avoid a problem with a white bar happening with narrow browsers windows caused the notification panel to not fully display. This revision reverts the problem, fixing the notifications panel but causing the original rendering issue to be present again. From Ben: When you shrink the width of the viewport a white bar cuts the screen in half w/o something like that fix. This happens alot with the chrome dev tools open on the right side. https://code.launchpad.net/~bac/juju-gui/rev_navbar_css/+merge/166130 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : TRIVIAL: Revert notifications panel CSS problem. #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	lib/views/stylesheet.less	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bac

10 years, 11 months ago (2013-05-28 20:06:28 UTC) #2

*** Submitted:

TRIVIAL: Revert notifications panel CSS problem.

A fix to avoid a problem with a white bar happening with narrow browsers
windows caused the notification panel to not fully display.  This revision
reverts the problem, fixing the notifications panel but causing the original
rendering issue to be present again.

From Ben: When you shrink the width of the viewport a white bar cuts the
screen in half w/o something like that fix. This happens alot with the chrome
dev tools open on the right side.

R=
CC=
https://codereview.appspot.com/9827045

Expand All Messages | Collapse All Messages