Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(90)

Issue 98250044: state/apiserver/upgrader: we don't need datadir

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by jameinel
Modified:
9 years, 10 months ago
Reviewers:
mp+219557, fwereade, axw
Visibility:
Public.

Description

state/apiserver/upgrader: we don't need datadir UnitUpgrader was a unique facade in that it was taking a "datadir" argument (only other one that does that currently is Client). However, it doesn't actually *do* anything with it, so lets not give it useless data that we have to manufacture. https://code.launchpad.net/~jameinel/juju-core/unit-upgrader-no-datadir/+merge/219557 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/root.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/upgrader/unitupgrader.go View 3 chunks +0 lines, -3 lines 0 comments Download
M state/apiserver/upgrader/unitupgrader_test.go View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 3
jameinel
Please take a look.
9 years, 10 months ago (2014-05-14 16:12:12 UTC) #1
axw
On 2014/05/14 16:12:12, jameinel wrote: > Please take a look. LGTM
9 years, 10 months ago (2014-05-14 23:54:06 UTC) #2
fwereade
9 years, 10 months ago (2014-05-15 09:44:49 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b