Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(576)

Issue 97880045: HA: peergrouper spins in local environment (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by vladislav.klyachin
Modified:
9 years, 10 months ago
Reviewers:
mp+217955, jameinel, fwereade, axw
Visibility:
Public.

Description

HA: peergrouper spins in local environment The peergrouper is intended to monitor the MongoDB replica health and make sure everything is functioning well. However, when run in the local provider, or in an upgraded environment (while we haven't finished all the upgrade steps), it spams the log file with: INFO juju.worker runner.go:260 start "peergrouper" ERROR juju.worker.peergrouper worker.go:137 peergrouper loop terminated: cannot get replica set status: cannot get replica set status: not running with --replSet This fix ensure NOT running of peergrouper worker in local environment. https://code.launchpad.net/~klyachin/juju-core/106-peergrouper-spins-in-localenv/+merge/217955 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : HA: peergrouper spins in local environment #

Patch Set 3 : HA: peergrouper spins in local environment #

Total comments: 9

Patch Set 4 : HA: peergrouper spins in local environment #

Patch Set 5 : HA: peergrouper spins in local environment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
A [revision details] View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine.go View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
M cmd/jujud/machine_test.go View 1 2 3 4 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14
vladislav.klyachin
Please take a look.
9 years, 11 months ago (2014-05-01 17:28:00 UTC) #1
axw
On 2014/05/01 17:28:00, vladislav.klyachin wrote: > Please take a look. LGTM
9 years, 11 months ago (2014-05-01 17:48:55 UTC) #2
fwereade
NOT LGTM without a test.
9 years, 11 months ago (2014-05-06 08:04:28 UTC) #3
fwereade
On 2014/05/06 08:04:28, fwereade wrote: > NOT LGTM without a test. and... maybe not *directly* ...
9 years, 11 months ago (2014-05-06 08:06:32 UTC) #4
vladislav.klyachin
Please take a look.
9 years, 10 months ago (2014-05-13 13:52:36 UTC) #5
vladislav.klyachin
On 2014/05/06 08:06:32, fwereade wrote: > On 2014/05/06 08:04:28, fwereade wrote: > > NOT LGTM ...
9 years, 10 months ago (2014-05-13 13:57:31 UTC) #6
axw
On 2014/05/13 13:57:31, vladislav.klyachin wrote: > I don't have an idea about unit test that ...
9 years, 10 months ago (2014-05-14 04:55:07 UTC) #7
vladislav.klyachin
Please take a look.
9 years, 10 months ago (2014-05-15 05:45:45 UTC) #8
vladislav.klyachin
On 2014/05/14 04:55:07, axw wrote: > On 2014/05/13 13:57:31, vladislav.klyachin wrote: > > I don't ...
9 years, 10 months ago (2014-05-15 05:47:22 UTC) #9
fwereade
Sorry, but on reflection we need to do this right. Peergrouper is new code, and ...
9 years, 10 months ago (2014-05-15 09:29:15 UTC) #10
jameinel
I think there are couple of tweaks still, but I'd rather see this land and ...
9 years, 10 months ago (2014-05-19 06:24:37 UTC) #11
vladislav.klyachin
Please take a look.
9 years, 10 months ago (2014-05-19 12:48:00 UTC) #12
vladislav.klyachin
On 2014/05/19 06:24:37, jameinel wrote: > I think there are couple of tweaks still, but ...
9 years, 10 months ago (2014-05-19 12:49:32 UTC) #13
vladislav.klyachin
9 years, 10 months ago (2014-05-19 13:56:00 UTC) #14
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b