Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(222)

Issue 97870044: Added json encoded for ServerErrors

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by hduran
Modified:
6 years ago
Reviewers:
mp+217860, gz
Visibility:
Public.

Description

Added json encoded for ServerErrors added jsonEncode function to novaservice that tries to convert the given error into a ServerError and call its AsJSON method or wrap the given error into a 500 ServerError which will contain the original error message. https://code.launchpad.net/~hduran-8/goose/json_encoded_errors/+merge/217860 Requires: https://code.launchpad.net/~hduran-8/goose/testservice_errors/+merge/217818 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Added json encoded for ServerErrors #

Total comments: 4

Patch Set 3 : Added json encoded for ServerErrors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -9 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M http/client.go View 1 2 2 chunks +21 lines, -5 lines 0 comments Download
M http/client_test.go View 1 2 1 chunk +41 lines, -0 lines 0 comments Download
M testservices/errors.go View 1 2 chunks +12 lines, -0 lines 0 comments Download
M testservices/novaservice/service.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
M testservices/novaservice/service_http.go View 1 3 chunks +5 lines, -3 lines 0 comments Download
M testservices/novaservice/service_http_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
hduran
Please take a look.
6 years, 1 month ago (2014-05-01 01:09:14 UTC) #1
hduran
Please take a look.
6 years ago (2014-05-02 15:39:55 UTC) #2
gz
LGTM. https://codereview.appspot.com/97870044/diff/20001/http/client.go File http/client.go (right): https://codereview.appspot.com/97870044/diff/20001/http/client.go#newcode62 http/client.go:62: return nil, err We seem to not be ...
6 years ago (2014-05-02 16:19:48 UTC) #3
hduran
6 years ago (2014-05-02 16:29:34 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b