Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2481)

Issue 97110043: Improve mgo testing

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by axw
Modified:
9 years, 11 months ago
Reviewers:
mp+218571, fwereade
Visibility:
Public.

Description

Improve mgo testing - Use testing.MgoSuite in the store package - Wait for "waiting for connections" message in mongod output before starting tests. - Fix testing.MgoInstance.DialInfo to configure the client based on whether TLS is being used. https://code.launchpad.net/~axwalk/juju-core/testing-mgo-wait-listening/+merge/218571 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -140 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
D store/mgo_test.go View 1 chunk +0 lines, -103 lines 0 comments Download
M store/store_test.go View 4 chunks +10 lines, -10 lines 0 comments Download
M testing/mgo.go View 8 chunks +78 lines, -27 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
9 years, 11 months ago (2014-05-07 08:36:20 UTC) #1
fwereade
9 years, 11 months ago (2014-05-07 12:13:24 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b