Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 9705045: Format inserting-score-fragments snippet nicer in the wake of issue 3187 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by dak
Modified:
10 years, 9 months ago
Reviewers:
Graham Percival
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Format inserting-score-fragments snippet nicer in the wake of issue 3187 Also Run scripts/auxiliar/makelsr.py

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M Documentation/snippets/inserting-score-fragments-above-a-staff,-as-markups.ly View 2 chunks +9 lines, -8 lines 0 comments Download
A + Documentation/snippets/new/inserting-score-fragments-above-a-staff,-as-markups.ly View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 2
Graham Percival
I think the original version was more general, but if it produces ugly output due ...
10 years, 10 months ago (2013-06-06 21:26:28 UTC) #1
dak
10 years, 10 months ago (2013-06-06 23:31:41 UTC) #2
On 2013/06/06 21:26:28, Graham Percival wrote:
> I think the original version was more general,

No, it wasn't.  Not having a clue about the alignment of the staff within the
score containing the tuning, it centered the whole score, in this case between
the top of the staff and the lowest note.  If you use the same code for
different tunings (or use notes with stems, or a treble clef), the staff will
move vertically accordingly.  Centering the score was probably the best one
could do without knowing where the staff was located within. But since the
baseline is now (namely after issue 3187 has been tackled) exactly on the middle
staff line (it was previously at the bottom or top of the score bounding box,
don't remember which), it is easy to do better.  It turned out that putting the
middle staff line on the base line did not look good after the preceding colon:
it made more sense to shift the score up half a staff space (half a colon height
would probably have been even better, but that's pretty much the same).

> but if it produces ugly output due to a bug then I guess I can't complain
about this change.

It produced output that really should have gotten additional manual fine-tuning
that would have required amending after any change in the contents of the score.
 In contrast, the current version is stable vertically.  You can change the
content of the score and the staff lines will stay put.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b