Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2136)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 96800044: add class attr to moinwiki, rst; improve alt attr code in moinwiki, rst, creole, markdown; fix #7 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by RogerHaase
Modified:
9 years, 11 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

add class attr to moinwiki and rst; improve alt attr code in moinwiki, rst, creole and markdown; fix #7

Patch Set 1 #

Total comments: 17

Patch Set 2 : simplify creole_in.py, simplifya few tests, other small corrections #

Total comments: 8

Patch Set 3 : replied to comments, minor code change #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -104 lines) Patch
M MoinMoin/converter/_tests/test_creole_in.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M MoinMoin/converter/_tests/test_image.py View 2 chunks +2 lines, -2 lines 0 comments Download
M MoinMoin/converter/_tests/test_include.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M MoinMoin/converter/_tests/test_markdown_in.py View 1 chunk +3 lines, -3 lines 0 comments Download
M MoinMoin/converter/_tests/test_moinwiki_in.py View 1 chunk +7 lines, -2 lines 0 comments Download
M MoinMoin/converter/_tests/test_moinwiki_in_out.py View 1 3 chunks +24 lines, -16 lines 0 comments Download
M MoinMoin/converter/_tests/test_moinwiki_out.py View 2 chunks +4 lines, -4 lines 0 comments Download
M MoinMoin/converter/creole_in.py View 1 2 chunks +8 lines, -14 lines 1 comment Download
M MoinMoin/converter/docbook_in.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M MoinMoin/converter/html_out.py View 1 2 3 chunks +19 lines, -8 lines 3 comments Download
M MoinMoin/converter/include.py View 1 5 chunks +13 lines, -9 lines 0 comments Download
M MoinMoin/converter/markdown_in.py View 1 chunk +3 lines, -2 lines 0 comments Download
M MoinMoin/converter/moinwiki_in.py View 2 chunks +4 lines, -11 lines 0 comments Download
M MoinMoin/converter/moinwiki_out.py View 7 chunks +39 lines, -20 lines 0 comments Download
M MoinMoin/converter/rst_in.py View 1 2 3 chunks +13 lines, -6 lines 0 comments Download
M MoinMoin/static/js/common.js View 2 chunks +13 lines, -1 line 0 comments Download
M MoinMoin/themes/foobar/static/css/common.css View 1 chunk +7 lines, -0 lines 0 comments Download
M MoinMoin/themes/foobar/static/css/stylus/userstyles.css View 1 chunk +7 lines, -0 lines 0 comments Download
M MoinMoin/themes/modernized/static/css/common.css View 2 chunks +7 lines, -1 line 0 comments Download
M MoinMoin/themes/modernized/static/css/stylus/userstyles.css View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6
RogerHaase
Added class attribute with possible values of left, center, right, top, middle, bottom to moinwiki ...
9 years, 12 months ago (2014-04-25 16:18:18 UTC) #1
Thomas.J.Waldmann
https://codereview.appspot.com/96800044/diff/1/MoinMoin/converter/_tests/test_include.py File MoinMoin/converter/_tests/test_include.py (right): https://codereview.appspot.com/96800044/diff/1/MoinMoin/converter/_tests/test_include.py#newcode88 MoinMoin/converter/_tests/test_include.py:88: assert '<p>before <em>italic <strong>bold <object class="moin-http moin-transclusion" data="http://moinmo.in" data-href="http://moinmo.in">my ...
9 years, 12 months ago (2014-04-25 21:14:20 UTC) #2
RogerHaase
https://codereview.appspot.com/96800044/diff/40001/MoinMoin/converter/_tests/test_moinwiki_in_out.py File MoinMoin/converter/_tests/test_moinwiki_in_out.py (right): https://codereview.appspot.com/96800044/diff/40001/MoinMoin/converter/_tests/test_moinwiki_in_out.py#newcode132 MoinMoin/converter/_tests/test_moinwiki_in_out.py:132: # output sequence of height, width, class may not ...
9 years, 12 months ago (2014-04-26 20:50:49 UTC) #3
Thomas.J.Waldmann
https://codereview.appspot.com/96800044/diff/1/MoinMoin/converter/_tests/test_include.py File MoinMoin/converter/_tests/test_include.py (right): https://codereview.appspot.com/96800044/diff/1/MoinMoin/converter/_tests/test_include.py#newcode88 MoinMoin/converter/_tests/test_include.py:88: assert '<p>before <em>italic <strong>bold <object class="moin-http moin-transclusion" data="http://moinmo.in" data-href="http://moinmo.in">my ...
9 years, 11 months ago (2014-05-03 20:23:40 UTC) #4
RogerHaase
https://codereview.appspot.com/96800044/diff/60001/MoinMoin/converter/creole_in.py File MoinMoin/converter/creole_in.py (right): https://codereview.appspot.com/96800044/diff/60001/MoinMoin/converter/creole_in.py#newcode418 MoinMoin/converter/creole_in.py:418: stack.top_append(element) re. ps2 comment: afaik, the stack.push seems to ...
9 years, 11 months ago (2014-05-06 15:46:38 UTC) #5
Thomas.J.Waldmann
9 years, 11 months ago (2014-05-11 14:13:02 UTC) #6 
https://codereview.appspot.com/96800044/diff/60001/MoinMoin/converter/html_ou...
File MoinMoin/converter/html_out.py (right):

https://codereview.appspot.com/96800044/diff/60001/MoinMoin/converter/html_ou...
MoinMoin/converter/html_out.py:362: del elem.attrib[moin_page.type_]
somehow such stuff reads a bit strange to me (I didn't look further into it
yet). checking stuff in one place and then removing it in another place...

maybe there could be some global review of such stuff in a separate cs.

if it was just the same place, one could just use .pop() ?

https://codereview.appspot.com/96800044/diff/60001/MoinMoin/converter/html_ou...
MoinMoin/converter/html_out.py:376: alt =
convert_getlink_to_showlink(unicode(href))
ok, i see
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b