Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2078)

Issue 96790048: corrects typo in bar-line.scm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by thomasmorley651
Modified:
9 years, 11 months ago
Reviewers:
marc
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

corrects typo in bar-line.scm issue 3908 Missing space in (define-bar-line ":|]" ":|]" #f " |") caused bad visual output of VoltaBracket. Changed to (define-bar-line ":|]" ":|]" #f " | ") The space added will cause that the SpanBar x-extent will be calculated correctly to determine the gap between two VoltaBrackets.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M scm/bar-line.scm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
thomasmorley651
Please review
9 years, 11 months ago (2014-04-28 09:35:27 UTC) #1
marc
9 years, 11 months ago (2014-04-28 15:57:42 UTC) #2
LGTM

Thanks for this patch!

Marc
Am 28.04.2014 11:35, schrieb thomasmorley65@gmail.com:
> Reviewers: ,
>
> Message:
> Please review
>
> Description:
> corrects typo in bar-line.scm
>
> issue 3908
>
> Missing space in (define-bar-line ":|]" ":|]" #f " |") caused bad
> visual output of VoltaBracket.
> Changed to (define-bar-line ":|]" ":|]" #f " | ")
> The space added will cause that the SpanBar x-extent will be calculated
> correctly to determine the gap between two VoltaBrackets.
>
> Please review this at https://codereview.appspot.com/96790048/
>
> Affected files (+1, -1 lines):
>    M scm/bar-line.scm
>
>
> Index: scm/bar-line.scm
> diff --git a/scm/bar-line.scm b/scm/bar-line.scm
> index
>
1f3c09d234e948e13e16e569603e909adfea0589..ff2d3f29b4a35d30cee581fa8f31ac096b06acb5
> 100644
> --- a/scm/bar-line.scm
> +++ b/scm/bar-line.scm
> @@ -1049,7 +1049,7 @@ of the volta brackets relative to the bar lines."
>   (define-bar-line ":|." ":|." #f " |.")
>   (define-bar-line ".|:" "|" ".|:" ".|")
>   (define-bar-line "[|:" "|" "[|:" " |")
> -(define-bar-line ":|]" ":|]" #f " |")
> +(define-bar-line ":|]" ":|]" #f " | ")
>   (define-bar-line ":|][|:" ":|]" "[|:" " |  |")
>   (define-bar-line ".|:-||" "||" ".|:" ".|")
>
>
>
>
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
>

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b