Issue 9651047: code review 9651047: os: request appropriate access rights before calling wi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9651047: code review 9651047: os: request appropriate access rights before calling wi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by brainman

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

os: request appropriate access rights before calling windows TerminateProcess Fixes issue 5615.

Patch Set 1 #

Patch Set 2 : diff -r 4aa7943034c5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4aa7943034c5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r fe447e02dc0b https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r fe447e02dc0b https://go.googlecode.com/hg/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -2 lines)			Patch
M	src/pkg/os/exec_windows.go	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
M	src/pkg/os/os_test.go	View	1 2 3	2 chunks	+71 lines, -0 lines	0 comments	Download
M	src/pkg/syscall/ztypes_windows.go	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 10 months ago (2013-06-07 04:40:32 UTC) #1

rsc

If you get the process from StartProcess, not from FindProcess, does the extra request here ...

10 years, 10 months ago (2013-06-10 18:52:05 UTC) #2

brainman

On 2013/06/10 18:52:05, rsc wrote: > If you get the process from StartProcess, not from ...

10 years, 10 months ago (2013-06-11 02:48:32 UTC) #3

brainman

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

10 years, 10 months ago (2013-06-11 02:48:47 UTC) #4

brainman

10 years, 10 months ago (2013-06-11 03:06:45 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=50b14678c440 ***

os: request appropriate access rights before calling windows TerminateProcess

Fixes issue 5615.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/9651047

Expand All Messages | Collapse All Messages