Issue 9646043: Allow "juju-origin: lp:juju" in env.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9646043: Allow "juju-origin: lp:juju" in env.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by teknico

Modified:
10 years, 11 months ago

Reviewers:
bac, jeff.pihach, mp+165135

Visibility:
Public.

Description

Allow "juju-origin: lp:juju" in env. Fix charm to work when juju-origin is set to lp:juju in the environment. QAed with both lp:juju and ppa as values. https://code.launchpad.net/~teknico/charms/precise/juju-gui/1130681-upstart-with-origin-juju/+merge/165135 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Allow "juju-origin: lp:juju" in env. #

Patch Set 3 : Allow "juju-origin: lp:juju" in env. #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	HACKING.md	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	README.md	View		1 chunk	+2 lines, -4 lines	0 comments	Download
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	config/juju-api-agent.conf.template	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

LGTM with an expanded comment as discussed. https://codereview.appspot.com/9646043/diff/1/HACKING.md File HACKING.md (right): https://codereview.appspot.com/9646043/diff/1/HACKING.md#newcode35 HACKING.md:35: cd juju-jitsu ...

10 years, 11 months ago (2013-05-22 15:18:25 UTC) #3

teknico

10 years, 11 months ago (2013-05-22 15:30:11 UTC) #5

*** Submitted:

Allow "juju-origin: lp:juju" in env.

Fix charm to work when juju-origin is set to lp:juju in the environment.
QAed with both lp:juju and ppa as values.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/9646043

Expand All Messages | Collapse All Messages