Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(880)

Issue 96440043: worker/instancepoller: TestBatching less race-y

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by axw
Modified:
9 years, 10 months ago
Reviewers:
mp+220014, wallyworld
Visibility:
Public.

Description

worker/instancepoller: TestBatching less race-y The existing TestBatching test was very prone to failure due to the nature of the test. The test ensures that requests to Instances are batched using a token bucket. Whereas the existing test streamed requests, the new implementation compresses the addition of requests into the point where we service an Instances call. We can thus reliably determine the number of batches that will be made, as calls to Instances must complete before additional requests are gathered. Fixes lp:1319652 https://code.launchpad.net/~axwalk/juju-core/lp1319652-instancepoller-testbatching/+merge/220014 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -24 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M worker/instancepoller/aggregate_test.go View 1 chunk +46 lines, -24 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
9 years, 10 months ago (2014-05-19 11:34:48 UTC) #1
wallyworld
9 years, 10 months ago (2014-05-19 22:56:32 UTC) #2
Nice. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b