Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1919)

Issue 9611047: s3: close http response Body properly

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by niemeyer
Modified:
10 years, 10 months ago
Reviewers:
mp+164913, dfc
Visibility:
Public.

Description

s3: close http response Body properly The interface of the run method was error prone. https://code.launchpad.net/~niemeyer/goamz/close-resp-body/+merge/164913 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : s3: close http response Body properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -15 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M s3/multi.go View 1 chunk +3 lines, -2 lines 0 comments Download
M s3/s3.go View 4 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 4
niemeyer
Please take a look.
10 years, 10 months ago (2013-05-21 15:02:53 UTC) #1
dfc
LGTM. Thank you, closing is hard.
10 years, 10 months ago (2013-05-22 01:32:54 UTC) #2
anacrolix
10 years, 10 months ago (2013-05-22 04:38:33 UTC) #3
niemeyer
10 years, 10 months ago (2013-05-22 15:53:14 UTC) #4
*** Submitted:

s3: close http response Body properly

The interface of the run method was error prone.

R=dfc, anacrolix
CC=
https://codereview.appspot.com/9611047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b