Add juju-tools endpoint to test identity service

Add juju-tools endpoint to test identity service

The identity service double now exposes a juju-tools endpoint so
that the user's env no longer needs to define a public-bucket-url.

Some tests were failing also. One issue was a code conflict that was
fixed by adding the AddService method to the IdentityService interface.
The other issue was that the KeyPairRequest struct used in the keypair
service double was defined with incorrect json tags.

A bit of drive-by cleanup was also done.

https://code.launchpad.net/~wallyworld/goose/juju-tools-endpoint/+merge/164820

(do not edit description out of merge proposal)

[wallyworld, 2013-05-21 01:21:55]

Please take a look.

[dimitern, 2013-05-21 07:39:41]

Thanks for taking the time to fix these. LGTM with a couple of suggestions.

https://codereview.appspot.com/9603044/diff/1/client/live_test.go
File client/live_test.go (right):

https://codereview.appspot.com/9603044/diff/1/client/live_test.go#newcode51
client/live_test.go:51: cl := client.NewClient(s.cred, s.authMode, nil)
i'm not too keen on this change - didn't we decide to use longer names when
possible?

https://codereview.appspot.com/9603044/diff/1/client/local_test.go
File client/local_test.go (right):

https://codereview.appspot.com/9603044/diff/1/client/local_test.go#newcode59
client/local_test.go:59:
s.service.(*openstackservice.Openstack).Identity.AddService(serviceDef)
nice!

https://codereview.appspot.com/9603044/diff/1/identity/keypair.go
File identity/keypair.go (right):

https://codereview.appspot.com/9603044/diff/1/identity/keypair.go#newcode3
identity/keypair.go:3: import (
why introduce 2 extra lines for no good reason?

[wallyworld, 2013-05-22 07:19:51]

https://codereview.appspot.com/9603044/diff/1/client/live_test.go
File client/live_test.go (right):

https://codereview.appspot.com/9603044/diff/1/client/live_test.go#newcode51
client/live_test.go:51: cl := client.NewClient(s.cred, s.authMode, nil)
On 2013/05/21 07:39:41, dimitern wrote:
> i'm not too keen on this change - didn't we decide to use longer names when
> possible?

cl has been used elsewhere. The reason for the change is that using "client" is
incorrect as it clashes with the package name.

https://codereview.appspot.com/9603044/diff/1/identity/keypair.go
File identity/keypair.go (right):

https://codereview.appspot.com/9603044/diff/1/identity/keypair.go#newcode3
identity/keypair.go:3: import (
On 2013/05/21 07:39:41, dimitern wrote:
> why introduce 2 extra lines for no good reason?

So that it's consistent with most other imports which are multiline. So just
consistency/cosmetics.

[jameinel, 2013-05-22 10:57:30]

LGTM