Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2039)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 95920043: Make doc comments everywhere match function names

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by menn0
Modified:
9 years, 11 months ago
Reviewers:
gz, mp+217859
Visibility:
Public.

Description

Make doc comments everywhere match function names https://code.launchpad.net/~menno.smits/juju-core/more_doc_comment_fixes/+merge/217859 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -67 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cert/cert.go View 1 chunk +1 line, -1 line 0 comments Download
M cloudinit/options.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/machine.go View 2 chunks +3 lines, -2 lines 0 comments Download
M constraints/validation.go View 1 chunk +3 lines, -2 lines 0 comments Download
M environs/bootstrap/state_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/configstore/disk.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/filestorage/filestorage.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/httpstorage/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/simplestreams/simplestreams.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/sync/sync.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/testing/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/tools/testing/testing.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/tools/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M instance/address.go View 1 chunk +3 lines, -3 lines 0 comments Download
M juju/arch/arch.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/osenv/home.go View 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/instance.go View 1 chunk +3 lines, -3 lines 0 comments Download
M names/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/azure/environ_test.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/common/bootstrap.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/common/state.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/ec2/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/environ_instance.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/joyent/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/local/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/environ.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/maas/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/provider.go View 1 chunk +1 line, -1 line 0 comments Download
M provider/openstack/storage.go View 1 chunk +1 line, -1 line 0 comments Download
M state/addmachine.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/apiclient.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/client.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/common/apiaddresser.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/params/apierror.go View 1 chunk +1 line, -1 line 0 comments Download
M state/api/uniter/charm.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/apiserver.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/charmrevisionupdater/updater.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/client/client.go View 1 chunk +1 line, -1 line 1 comment Download
M state/apiserver/common/addresses.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/common/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M state/apiserver/keymanager/keymanager.go View 2 chunks +2 lines, -2 lines 0 comments Download
M state/megawatcher_internal_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state.go View 1 chunk +1 line, -1 line 0 comments Download
M state/testing/watcher.go View 1 chunk +1 line, -1 line 0 comments Download
M state/unit.go View 1 chunk +1 line, -1 line 0 comments Download
M state/watcher.go View 1 chunk +1 line, -1 line 0 comments Download
M store/server.go View 1 chunk +1 line, -1 line 0 comments Download
M store/store.go View 1 chunk +1 line, -1 line 0 comments Download
M tools/list.go View 1 chunk +1 line, -1 line 0 comments Download
M utils/fslock/fslock.go View 1 chunk +2 lines, -2 lines 0 comments Download
M worker/firewaller/firewaller.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/uniter/debug/common_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
menn0
Please take a look.
9 years, 11 months ago (2014-05-01 00:58:20 UTC) #1
gz
9 years, 11 months ago (2014-05-01 01:11:24 UTC) #2 
LGTM. You should include the regexpes we used in the commit message.

https://codereview.appspot.com/95920043/diff/1/state/apiserver/client/client.go
File state/apiserver/client/client.go (right):

https://codereview.appspot.com/95920043/diff/1/state/apiserver/client/client....
state/apiserver/client/client.go:1068: // APIHostPorts returns the API host/port
addresses stored in state.
Aha! This is the one I'd seen before.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b