Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(797)

Issue 95850044: cmd/juju: helpful message is repetitive

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by vladislav.klyachin
Modified:
9 years, 12 months ago
Reviewers:
dimitern, mp+217645
Visibility:
Public.

Description

cmd/juju: helpful message is repetitive ubuntu@winton-02:~/src/launchpad.net/juju-core$ juju bootstrap ERROR failed verification of local provider prerequisites: juju-local must be installed to enable the local provider: sudo apt-get install juju-local ERROR juju-local must be installed to enable the local provider: sudo apt-get install juju-local This message was printed twice because of the following code: if err != nil { logger.Errorf("failed with error: %v", err) return nil, err } Such code was changed in some places to: if err != nil { return nil, fmt.Errors("failed with error: %v", err) } https://code.launchpad.net/~klyachin/juju-core/105-juju-bootstrap-repetative-message/+merge/217645 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/juju: helpful message is repetitive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/environ_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M provider/local/environprovider.go View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3
vladislav.klyachin
Please take a look.
9 years, 12 months ago (2014-04-29 17:06:45 UTC) #1
dimitern
LGTM
9 years, 12 months ago (2014-04-30 20:40:34 UTC) #2
vladislav.klyachin
9 years, 12 months ago (2014-05-01 19:08:20 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b