Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(422)

Issue 95780044: utils/ssh: Override rsa.GenerateKey in tests

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by gz
Modified:
9 years, 11 months ago
Reviewers:
mp+217314, jameinel
Visibility:
Public.

Description

utils/ssh: Override rsa.GenerateKey in tests Make ssh tests faster by generating one, smaller, RSA key and reusing it for all tests. This is particularly helpful on arm where the math prime functions are very slow. https://code.launchpad.net/~gz/juju-core/generatekey_testoverride_1312850/+merge/217314 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/ssh/clientkeys_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/ssh/export_test.go View 1 chunk +1 line, -0 lines 0 comments Download
M utils/ssh/generate.go View 2 chunks +3 lines, -1 line 0 comments Download
M utils/ssh/generate_test.go View 2 chunks +20 lines, -0 lines 0 comments Download
M utils/ssh/ssh_gocrypto_test.go View 1 chunk +2 lines, -0 lines 0 comments Download
M utils/ssh/ssh_test.go View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
9 years, 11 months ago (2014-04-26 00:00:45 UTC) #1
jameinel
9 years, 11 months ago (2014-04-26 04:38:10 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b