Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 95150044: RFC6962-bis: Tree and leaf versioning (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Eran
Modified:
8 years ago
CC:
ctlog-opensource-review_google.com
Visibility:
Public.

Description

RFC6962-bis: Tree and leaf versioning. Since we've added the extensions field to the STH, we need to increase its version. Might as well create a separate versioning scheme for it and the tree leaves so each can be changed independently.

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressing review comments #

Total comments: 4

Patch Set 3 : Re-wording based on suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M doc/rfc6962-bis.xml View 1 2 5 chunks +13 lines, -9 lines 0 comments Download

Messages

Total messages: 7
Eran
8 years, 1 month ago (2014-05-08 15:55:06 UTC) #1
Rob Stradling
https://codereview.appspot.com/95150044/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/95150044/diff/1/doc/rfc6962-bis.xml#newcode717 doc/rfc6962-bis.xml:717: Here, <spanx style="verb">version</spanx> is the version of the protocol ...
8 years, 1 month ago (2014-05-09 11:01:06 UTC) #2
Eran
https://codereview.appspot.com/95150044/diff/1/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/95150044/diff/1/doc/rfc6962-bis.xml#newcode717 doc/rfc6962-bis.xml:717: Here, <spanx style="verb">version</spanx> is the version of the protocol ...
8 years, 1 month ago (2014-05-09 12:43:47 UTC) #3
Rob Stradling
https://codereview.appspot.com/95150044/diff/20001/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/95150044/diff/20001/doc/rfc6962-bis.xml#newcode759 doc/rfc6962-bis.xml:759: <spanx style="verb">version</spanx> is the version of the TreeHeadSignature signature. ...
8 years, 1 month ago (2014-05-12 12:53:54 UTC) #4
Eran
Done, PTAL. https://codereview.appspot.com/95150044/diff/20001/doc/rfc6962-bis.xml File doc/rfc6962-bis.xml (right): https://codereview.appspot.com/95150044/diff/20001/doc/rfc6962-bis.xml#newcode759 doc/rfc6962-bis.xml:759: <spanx style="verb">version</spanx> is the version of the ...
8 years, 1 month ago (2014-05-21 16:22:25 UTC) #5
Rob Stradling
LGTM
8 years, 1 month ago (2014-05-23 09:43:24 UTC) #6
Eran
8 years ago (2014-06-11 12:46:21 UTC) #7
On 2014/05/23 09:43:24, Rob Stradling wrote:
> LGTM

Committed as
https://github.com/google/certificate-transparency-rfcs/commit/5bb9a5487c93f4...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b