Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 95150043: environs/manual: use old AddMAchines API

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by axw
Modified:
6 years, 4 months ago
Reviewers:
gz, mp+218746
Visibility:
Public.

Description

environs/manual: use old AddMAchines API Manual provisioning was implicitly changed to use the new AddMachinesV2 client API, with no backwards compatibility failover. I've changed it to explicitly use the old API, since we do not require anything of the new one. Fixes lp:1317267 https://code.launchpad.net/~axwalk/juju-core/lp1317267-manual-addmachine1dot18/+merge/218746 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/manual: use old AddMAchines API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M environs/manual/provisioner.go View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
axw
Please take a look.
6 years, 4 months ago (2014-05-08 07:02:05 UTC) #1
gz
LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.
6 years, 4 months ago (2014-05-08 07:55:11 UTC) #2
gz
LGTM. A comment here saying only the 1.18 api is needed wouldn't hurt.
6 years, 4 months ago (2014-05-08 07:55:13 UTC) #3
axw
6 years, 4 months ago (2014-05-08 10:10:35 UTC) #4
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b