Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1006)

Issue 9496043: code review 9496043: cmd/vet: delete; it now lives in the go.tools subrepo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by r
Modified:
12 years, 2 months ago
Reviewers:
CC:
golang-dev, dsymonds, rsc, iant, dave_cheney.net
Visibility:
Public.

Description

cmd/vet: delete; it now lives in the go.tools subrepo

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r 5f76ce908c8f https://code.google.com/p/go #

Patch Set 3 : diff -r 4cb93e2900d0 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5753 lines) Patch
R src/cmd/vet/Makefile View 1 chunk +0 lines, -14 lines 0 comments Download
R src/cmd/vet/asmdecl.go View 1 chunk +0 lines, -533 lines 0 comments Download
R src/cmd/vet/assign.go View 1 chunk +0 lines, -44 lines 0 comments Download
R src/cmd/vet/atomic.go View 1 chunk +0 lines, -59 lines 0 comments Download
R src/cmd/vet/buildtag.go View 1 chunk +0 lines, -91 lines 0 comments Download
R src/cmd/vet/deadcode.go View 1 chunk +0 lines, -280 lines 0 comments Download
R src/cmd/vet/doc.go View 1 chunk +0 lines, -76 lines 0 comments Download
R src/cmd/vet/main.go View 1 chunk +0 lines, -422 lines 0 comments Download
R src/cmd/vet/method.go View 1 chunk +0 lines, -162 lines 0 comments Download
R src/cmd/vet/print.go View 1 chunk +0 lines, -351 lines 0 comments Download
R src/cmd/vet/rangeloop.go View 1 chunk +0 lines, -65 lines 0 comments Download
R src/cmd/vet/structtag.go View 1 chunk +0 lines, -37 lines 0 comments Download
R src/cmd/vet/taglit.go View 1 chunk +0 lines, -164 lines 0 comments Download
R src/cmd/vet/test_asm.go View 1 chunk +0 lines, -24 lines 0 comments Download
R src/cmd/vet/test_asm1.s View 1 chunk +0 lines, -247 lines 0 comments Download
R src/cmd/vet/test_asm2.s View 1 chunk +0 lines, -251 lines 0 comments Download
R src/cmd/vet/test_asm3.s View 1 chunk +0 lines, -166 lines 0 comments Download
R src/cmd/vet/test_assign.go View 1 chunk +0 lines, -20 lines 0 comments Download
R src/cmd/vet/test_atomic.go View 1 chunk +0 lines, -43 lines 0 comments Download
R src/cmd/vet/test_buildtag.go View 1 chunk +0 lines, -15 lines 0 comments Download
R src/cmd/vet/test_buildtag_bad.go View 1 chunk +0 lines, -15 lines 0 comments Download
R src/cmd/vet/test_deadcode.go View 1 chunk +0 lines, -2121 lines 0 comments Download
R src/cmd/vet/test_method.go View 1 chunk +0 lines, -24 lines 0 comments Download
R src/cmd/vet/test_print.go View 1 chunk +0 lines, -153 lines 0 comments Download
R src/cmd/vet/test_rangeloop.go View 1 chunk +0 lines, -61 lines 0 comments Download
R src/cmd/vet/test_structtag.go View 1 chunk +0 lines, -15 lines 0 comments Download
R src/cmd/vet/test_taglit.go View 1 chunk +0 lines, -65 lines 0 comments Download
R src/cmd/vet/types.go View 1 chunk +0 lines, -185 lines 0 comments Download
R src/cmd/vet/typestub.go View 1 chunk +0 lines, -50 lines 0 comments Download

Messages

Total messages: 9
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
12 years, 2 months ago (2013-05-17 20:04:22 UTC) #1
dsymonds
Should the dir be "govet", so installing it with the go tool will use the ...
12 years, 2 months ago (2013-05-17 20:09:42 UTC) #2
rsc
I don't see what this has to do with the CL at hand, but the ...
12 years, 2 months ago (2013-05-17 20:14:18 UTC) #3
iant
https://codereview.appspot.com/9496043/diff/1/test/bench/shootout/timing.log File test/bench/shootout/timing.log (right): https://codereview.appspot.com/9496043/diff/1/test/bench/shootout/timing.log#newcode6 test/bench/shootout/timing.log:6: # sudo apt-get install libpcre3-dev This seems like an ...
12 years, 2 months ago (2013-05-17 20:32:39 UTC) #4
r
Hello golang-dev@googlegroups.com, dsymonds@golang.org, rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
12 years, 2 months ago (2013-05-17 20:33:29 UTC) #5
r
indeed it was. i had a CL to hold that hostage but the CL is ...
12 years, 2 months ago (2013-05-17 20:33:49 UTC) #6
dave_cheney.net
Now there is a new subrepo, can someone with permissions please redeploy build.golang.org to cover ...
12 years, 2 months ago (2013-05-17 20:42:59 UTC) #7
iant
LGTM
12 years, 2 months ago (2013-05-17 20:48:29 UTC) #8
r
12 years, 2 months ago (2013-05-17 20:53:26 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=43b3233f0b5b ***

cmd/vet: delete; it now lives in the go.tools subrepo

R=golang-dev, dsymonds, rsc, iant, dave
CC=golang-dev
https://codereview.appspot.com/9496043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b