CSS housekeeping

CSS housekeeping

Did a bunch of CSS cleanups to make things more consistent:

Grouped mixins together.
Grouped common classes and overrides together
Added gradient mixin.
Consistent formatting, order, indentation etc. using the following pattern:

.class {
    @vars;
    .mixins;
    properties: values;

    .sub-classes {
    }
    .sub-classes2 {
    }
}

https://code.launchpad.net/~huwshimi/juju-gui/css-cleanup/+merge/164308

(do not edit description out of merge proposal)

[huwshimi, 2013-05-17 06:58:11]

Please take a look.

[curtis, 2013-05-20 20:57:16]

Thank you Huw. LGTM.

Do you need assistance landing this branch? Ping me if so.

[rharding, 2013-05-22 14:59:54]

LGTM with a couple of comments below.

https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:62: background-color: #302b28;
how do you feel about alphabetical rules? In vim you can highlight them and run
a :!sort to auto sort them in one swoop.

https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:102: ::-webkit-scrollbar {
I'd be curious to see where this is headed with the blink change in chrome as
they work to un-prefix things. 

:edit: nvm, looks like it's a forward moving thing per
http://www.chromium.org/blink#vendor-prefixes

https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:1107: //XXX was this intended to be "&:last-child"?
If you're adding an XXX please file a bug so that it has a notice to be followed
up upon.

https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:1176: // XXX: This doesn't seem to make sense here:
again, maybe a css clarification bug or card at the least.

[huwshimi, 2013-05-30 00:08:02]

Oh, I missed this review, thanks Rick...


On 2013/05/22 14:59:54, rharding wrote:
> LGTM with a couple of comments below.
> 
> https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less
> File lib/views/stylesheet.less (right):
> 
>
https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
> lib/views/stylesheet.less:62: background-color: #302b28;
> how do you feel about alphabetical rules? In vim you can highlight them and
run
> a :!sort to auto sort them in one swoop.

I think that having properties grouped together for function is better than by
alphabet and it's nice to group all the vendor prefix classes and there are also
a bunch of cases where the order of properties matter, but happy to be convinced
otherwise.

> 
>
https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
> lib/views/stylesheet.less:102: ::-webkit-scrollbar {
> I'd be curious to see where this is headed with the blink change in chrome as
> they work to un-prefix things. 
> 
> :edit: nvm, looks like it's a forward moving thing per
> http://www.chromium.org/blink#vendor-prefixes

That code will have to be dropped at some stage once we implement custom
scrollbars.

> 
>
https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
> lib/views/stylesheet.less:1107: //XXX was this intended to be "&:last-child"?
> If you're adding an XXX please file a bug so that it has a notice to be
followed
> up upon.
> 
>
https://codereview.appspot.com/9462043/diff/1/lib/views/stylesheet.less#newco...
> lib/views/stylesheet.less:1176: // XXX: This doesn't seem to make sense here:
> again, maybe a css clarification bug or card at the least.

I'll file some XXX bugs.

[huwshimi, 2013-05-30 03:40:01]

*** Submitted:

CSS housekeeping

Did a bunch of CSS cleanups to make things more consistent:

Grouped mixins together.
Grouped common classes and overrides together
Added gradient mixin.
Consistent formatting, order, indentation etc. using the following pattern:

.class {
    @vars;
    .mixins;
    properties: values;

    .sub-classes {
    }
    .sub-classes2 {
    }
}

R=curtis, rharding
CC=
https://codereview.appspot.com/9462043