Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 9443043: Introduced sandbox tests.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by frankban
Modified:
10 years, 10 months ago
Reviewers:
teknico, mp+164142, gary.poster
Visibility:
Public.

Description

Introduced sandbox tests. CI machinery now includes a way to change charm options. A test has been added exercising charm deployment in sandbox mode. The web driver is now instantiated for each test case (rather than once for all the suite). This way a test run is slightly slower, but more reliable, especially when using the Firefox driver. Fixed a Firefox error introduced by new initial placement of deployed services: for some reason Selenium/Firefox was unable to retrieve the text content (i.e. the service name) if the service box node is not visible to the user. Solved zooming out before checking for service names: not horrible, since this way the newly deployed services can also be seen on the Saucelabs videos. Also added a new JUJU_GUI_TEST_BROWSERS: specifying "local", a local Firefox driver is used in place of the remote Saucelabs one. This can be useful, e.g. when debugging. https://code.launchpad.net/~frankban/juju-gui/sandbox-selenium/+merge/164142 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 9

Patch Set 2 : Introduced sandbox tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -55 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M docs/continuous-integration.rst View 1 chunk +3 lines, -1 line 0 comments Download
M test/browser.py View 1 10 chunks +85 lines, -37 lines 0 comments Download
M test/test_charm_running.py View 3 chunks +60 lines, -17 lines 0 comments Download

Messages

Total messages: 7
frankban
Please take a look.
10 years, 10 months ago (2013-05-16 09:46:11 UTC) #1
teknico
LGTM, great changes. QA with successful with both local browser and Saucelabs, thanks for the ...
10 years, 10 months ago (2013-05-16 11:45:33 UTC) #2
gary.poster
LGTM! Very cool. All comments are suggestion, possibly for the future: feel free to ignore. ...
10 years, 10 months ago (2013-05-16 12:23:26 UTC) #3
frankban
On 2013/05/16 12:23:26, gary.poster wrote: > LGTM! Very cool. All comments are suggestion, possibly for ...
10 years, 10 months ago (2013-05-16 13:33:15 UTC) #4
frankban
https://codereview.appspot.com/9443043/diff/1/docs/continuous-integration.rst File docs/continuous-integration.rst (right): https://codereview.appspot.com/9443043/diff/1/docs/continuous-integration.rst#newcode43 docs/continuous-integration.rst:43: want to use a local web driver (Firefox) instead, ...
10 years, 10 months ago (2013-05-16 13:33:29 UTC) #5
frankban
*** Submitted: Introduced sandbox tests. CI machinery now includes a way to change charm options. ...
10 years, 10 months ago (2013-05-16 13:53:43 UTC) #6
teknico
10 years, 10 months ago (2013-05-16 14:00:31 UTC) #7
https://codereview.appspot.com/9443043/diff/1/docs/continuous-integration.rst
File docs/continuous-integration.rst (right):

https://codereview.appspot.com/9443043/diff/1/docs/continuous-integration.rst...
docs/continuous-integration.rst:44: to local, e.g.
``JUJU_GUI_TEST_BROWSERS=local bin/test-charm``.
frankban wrote:
> Just curious, any particular reason to prefer having quotes in this case?

Because they delimit the env var value, as in "chrome firefox ie" above,
irrespective of how many words are in the value.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b