Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3668)

Issue 94410046: testing: reattempt MgoInstance.run if addr in use

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by axw
Modified:
5 years, 9 months ago
Reviewers:
wallyworld, mp+219456
Visibility:
Public.

Description

testing: reattempt MgoInstance.run if addr in use Mongod does not support listening on port 0 to acquire an ephemeral port, so our tests must choose a port which may then be allocated to another process. This CL adds code to reattempt the starting of mongod if the port is in use, up to a maximum of 5 attempts. https://code.launchpad.net/~axwalk/juju-core/testing-mgo-addrinuse/+merge/219456 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: reattempt MgoInstance.run if addr in use #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M testing/mgo.go View 1 5 chunks +38 lines, -13 lines 0 comments Download

Messages

Total messages: 3
axw
Please take a look.
5 years, 9 months ago (2014-05-14 05:35:06 UTC) #1
wallyworld
LGTM
5 years, 9 months ago (2014-05-14 06:43:15 UTC) #2
axw
5 years, 9 months ago (2014-05-14 07:46:25 UTC) #3
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b