Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1465)

Issue 9425046: code review 9425046: compress/flate: faster version of forwardCopy (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by khr
Modified:
10 years, 10 months ago
Reviewers:
nigeltao
CC:
nigeltao, bradfitz, golang-dev, raph
Visibility:
Public.

Description

compress/flate: faster version of forwardCopy benchmark old ns/op new ns/op delta BenchmarkDecodeDigitsSpeed1e4 197767 203490 +2.89% BenchmarkDecodeDigitsSpeed1e5 1873969 1912761 +2.07% BenchmarkDecodeDigitsSpeed1e6 18922760 19021056 +0.52% BenchmarkDecodeDigitsDefault1e4 194975 197054 +1.07% BenchmarkDecodeDigitsDefault1e5 1704262 1719988 +0.92% BenchmarkDecodeDigitsDefault1e6 16618354 16351957 -1.60% BenchmarkDecodeDigitsCompress1e4 195281 194626 -0.34% BenchmarkDecodeDigitsCompress1e5 1694364 1702372 +0.47% BenchmarkDecodeDigitsCompress1e6 16463347 16492126 +0.17% BenchmarkDecodeTwainSpeed1e4 200653 200127 -0.26% BenchmarkDecodeTwainSpeed1e5 1861385 1759632 -5.47% BenchmarkDecodeTwainSpeed1e6 18255769 17186679 -5.86% BenchmarkDecodeTwainDefault1e4 189080 185157 -2.07% BenchmarkDecodeTwainDefault1e5 1559222 1461465 -6.27% BenchmarkDecodeTwainDefault1e6 14792125 13879051 -6.17% BenchmarkDecodeTwainCompress1e4 188881 185151 -1.97% BenchmarkDecodeTwainCompress1e5 1537031 1456945 -5.21% BenchmarkDecodeTwainCompress1e6 14805972 13405094 -9.46% BenchmarkPaeth 4 4 -0.89% BenchmarkDecodeGray 964679 937244 -2.84% BenchmarkDecodeNRGBAGradient 3753769 3646416 -2.86% BenchmarkDecodeNRGBAOpaque 3165856 2981300 -5.83% BenchmarkDecodePaletted 713950 691984 -3.08% BenchmarkDecodeRGB 3051718 2924260 -4.18%

Patch Set 1 #

Patch Set 2 : diff -r 9f146b985681 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 43b3233f0b5b https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 4 : diff -r 43b3233f0b5b https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r 43b3233f0b5b https://khr%40golang.org@code.google.com/p/go/ #

Total comments: 1

Patch Set 6 : diff -r 731724b03c62 https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M src/pkg/compress/flate/copy.go View 1 2 3 4 5 1 chunk +21 lines, -6 lines 0 comments Download
M src/pkg/compress/flate/copy_test.go View 1 1 chunk +6 lines, -4 lines 0 comments Download
M src/pkg/compress/flate/inflate.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
bradfitz
How does this do now?
10 years, 10 months ago (2013-05-17 21:24:33 UTC) #1
khr1
It gets about a 5% improvement. Not much, I think because most of the forwardCopy ...
10 years, 10 months ago (2013-05-17 22:00:38 UTC) #2
bradfitz
Seems worth it. On Fri, May 17, 2013 at 3:00 PM, Keith Randall <khr@google.com> wrote: ...
10 years, 10 months ago (2013-05-17 22:05:57 UTC) #3
khr
Hello bradfitz@golang.org, khr@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 10 months ago (2013-05-17 22:16:44 UTC) #4
bradfitz
I defer to others on this. On Fri, May 17, 2013 at 3:16 PM, <khr@golang.org> ...
10 years, 10 months ago (2013-05-17 22:19:47 UTC) #5
nigeltao
LGTM. CC'ing Raph Levien, since we were just talking yesterday about optimizing flate. https://codereview.appspot.com/9425046/diff/6002/src/pkg/compress/flate/copy.go File ...
10 years, 10 months ago (2013-05-18 17:32:38 UTC) #6
nigeltao
Out of curiousity, can we also get a benchcmp for image/png?
10 years, 10 months ago (2013-05-18 17:52:27 UTC) #7
bradfitz
On Sat, May 18, 2013 at 10:52 AM, Nigel Tao <nigeltao@golang.org> wrote: > Out of ...
10 years, 10 months ago (2013-05-18 20:32:07 UTC) #8
bradfitz
processor : 7 vendor_id : GenuineIntel cpu family : 6 model : 30 model name ...
10 years, 10 months ago (2013-05-18 20:32:55 UTC) #9
khr
10 years, 10 months ago (2013-05-18 22:28:31 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=bd653e485f1d ***

compress/flate: faster version of forwardCopy

benchmark                           old ns/op    new ns/op    delta
BenchmarkDecodeDigitsSpeed1e4          197767       203490   +2.89%
BenchmarkDecodeDigitsSpeed1e5         1873969      1912761   +2.07%
BenchmarkDecodeDigitsSpeed1e6        18922760     19021056   +0.52%
BenchmarkDecodeDigitsDefault1e4        194975       197054   +1.07%
BenchmarkDecodeDigitsDefault1e5       1704262      1719988   +0.92%
BenchmarkDecodeDigitsDefault1e6      16618354     16351957   -1.60%
BenchmarkDecodeDigitsCompress1e4       195281       194626   -0.34%
BenchmarkDecodeDigitsCompress1e5      1694364      1702372   +0.47%
BenchmarkDecodeDigitsCompress1e6     16463347     16492126   +0.17%
BenchmarkDecodeTwainSpeed1e4           200653       200127   -0.26%
BenchmarkDecodeTwainSpeed1e5          1861385      1759632   -5.47%
BenchmarkDecodeTwainSpeed1e6         18255769     17186679   -5.86%
BenchmarkDecodeTwainDefault1e4         189080       185157   -2.07%
BenchmarkDecodeTwainDefault1e5        1559222      1461465   -6.27%
BenchmarkDecodeTwainDefault1e6       14792125     13879051   -6.17%
BenchmarkDecodeTwainCompress1e4        188881       185151   -1.97%
BenchmarkDecodeTwainCompress1e5       1537031      1456945   -5.21%
BenchmarkDecodeTwainCompress1e6      14805972     13405094   -9.46%
BenchmarkPaeth                          4            4   -0.89%
BenchmarkDecodeGray                964679       937244   -2.84%
BenchmarkDecodeNRGBAGradient      3753769      3646416   -2.86%
BenchmarkDecodeNRGBAOpaque        3165856      2981300   -5.83%
BenchmarkDecodePaletted            713950       691984   -3.08%
BenchmarkDecodeRGB                3051718      2924260   -4.18%

R=nigeltao, bradfitz
CC=golang-dev, raph
https://codereview.appspot.com/9425046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b