Issue 9422043: code review 9422043: go.exp/locale: added tables and algorithm to compute th...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9422043: code review 9422043: go.exp/locale: added tables and algorithm to compute th... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by mpvl

Modified:
10 years, 11 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

go.exp/locale: added tables and algorithm to compute the distance between two regions.

Patch Set 2 : diff -r 4da2cb5e2a51 https://code.google.com/p/go.exp/ #

Patch Set 3 : diff -r 4da2cb5e2a51 https://code.google.com/p/go.exp/ #

Total comments: 4

Patch Set 4 : diff -r b8df1134ab53 https://code.google.com/p/go.exp/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+228 lines, -2 lines)			Patch
M	locale/maketables.go	View	1 2 3	4 chunks	+95 lines, -1 line	0 comments	Download
A	locale/match.go	View	1	1 chunk	+29 lines, -0 lines	0 comments	Download
A	locale/match_test.go	View	1	1 chunk	+36 lines, -0 lines	0 comments	Download
M	locale/tables.go	View	1	1 chunk	+68 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpvl

Hello r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.exp/

10 years, 11 months ago (2013-05-14 20:01:44 UTC) #1

LGTM https://codereview.appspot.com/9422043/diff/5001/locale/maketables.go File locale/maketables.go (right): https://codereview.appspot.com/9422043/diff/5001/locale/maketables.go#newcode844 locale/maketables.go:844: log.Fatalf("currently only 32 groups supported, found %d", len(groups)) ...

10 years, 11 months ago (2013-05-14 20:14:58 UTC) #2

mpvl

10 years, 11 months ago (2013-05-14 23:22:38 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=c54473b81697&repo=exp ***

go.exp/locale: added tables and algorithm to compute the distance
between two regions.

R=r
CC=golang-dev
https://codereview.appspot.com/9422043

https://codereview.appspot.com/9422043/diff/5001/locale/maketables.go
File locale/maketables.go (right):

https://codereview.appspot.com/9422043/diff/5001/locale/maketables.go#newcode844
locale/maketables.go:844: log.Fatalf("currently only 32 groups supported, found
%d", len(groups))
On 2013/05/14 20:14:58, r wrote:
> s/currently //

Done.

https://codereview.appspot.com/9422043/diff/5001/locale/maketables.go#newcode890
locale/maketables.go:890: // Add bit vectors for increasingly larger distances
until a fixed point is reached.
On 2013/05/14 20:14:58, r wrote:
> increasingly large
> or
> larger
> not
> increasingly larger

Done.

Expand All Messages | Collapse All Messages