Issue 94010044: Adding find-bad-doc-comments.py

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 94010044: Adding find-bad-doc-comments.py

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by menn0

Modified:
9 years, 11 months ago

Reviewers:
gz, mp+217963

Visibility:
Public.

Description

Adding find-bad-doc-comments.py This tool searches a tree of Go code and locates cases where the function name that starts a doc comment doesn't appear to match the related function. https://code.launchpad.net/~menno.smits/juju-core/find-bad-doc-comments/+merge/217963 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -0 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	A	scripts/find-bad-doc-comments.py	View		1 chunk	+81 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

9 years, 11 months ago (2014-05-01 18:16:23 UTC) #2

LGTM, can nitpick/discuss style but that's for fun not any practical reason.

Expand All Messages | Collapse All Messages