Issue 9393043: code review 9393043: cmd/gc: improve syntax error for "import testing"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9393043: code review 9393043: cmd/gc: improve syntax error for "import testing" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by minux1

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

cmd/gc: improve syntax error for "import testing" for this program: package A import testing old diagnostics: pkg.go:2: syntax error: unexpected semicolon or newline, expecting string literal now: pkg.go:2: syntax error: missing import path; require quoted string Fixes issue 5332.

Patch Set 1 #

Patch Set 2 : diff -r d29da2ced72b https://code.google.com/p/go #

Patch Set 3 : diff -r d29da2ced72b https://code.google.com/p/go #

Patch Set 4 : diff -r d29da2ced72b https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r d29da2ced72b https://code.google.com/p/go #

Patch Set 6 : diff -r 8efe0c9d6a0d https://code.google.com/p/go/ #

Patch Set 7 : diff -r f43090f2eb42 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	src/cmd/gc/go.errors	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	src/cmd/gc/yerr.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 2 months ago (2013-05-13 18:33:27 UTC) #1

https://codereview.appspot.com/9393043/diff/1002/src/cmd/gc/yerr.h File src/cmd/gc/yerr.h (right): https://codereview.appspot.com/9393043/diff/1002/src/cmd/gc/yerr.h#newcode21 src/cmd/gc/yerr.h:21: "missing import path after package alias in import, forget ...

12 years, 2 months ago (2013-05-13 19:33:38 UTC) #2

minux1

PTAL. https://codereview.appspot.com/9393043/diff/1002/src/cmd/gc/yerr.h File src/cmd/gc/yerr.h (right): https://codereview.appspot.com/9393043/diff/1002/src/cmd/gc/yerr.h#newcode21 src/cmd/gc/yerr.h:21: "missing import path after package alias in import, ...

12 years, 2 months ago (2013-05-13 19:39:52 UTC) #3

minux1

12 years, 2 months ago (2013-05-14 20:19:33 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=f51b5497fa4c ***

cmd/gc: improve syntax error for "import testing"
for this program:
package A
import testing

old diagnostics:
pkg.go:2: syntax error: unexpected semicolon or newline, expecting string
literal

now:
pkg.go:2: syntax error: missing import path; require quoted string

Fixes issue 5332.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9393043

Expand All Messages | Collapse All Messages