Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(156)

Issue 9324044: code review 9324044: Improve source build support on darwin.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by amerine
Modified:
8 years, 7 months ago
Reviewers:
minux1, tim.olsen, iant, dfc, rsc, tim.olsen, golang-dev
Visibility:
Public.

Description

Improve source build support on darwin. Attempting to set the maximum number of open file descriptors causes all.bash runs to fail. Ensuring true returns allows the script to run.

Patch Set 1 #

Patch Set 2 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #

Patch Set 3 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 8f1fb6b6f141 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/run.bash View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20
amerine
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
9 years, 4 months ago (2013-05-14 06:20:50 UTC) #1
iant
What is the failure mode? What version of OS X are you running? I don't ...
9 years, 4 months ago (2013-05-14 13:44:38 UTC) #2
amerine
On May 14, 2013, at 6:44 AM, iant@golang.org wrote: > What is the failure mode? ...
9 years, 4 months ago (2013-05-14 16:08:11 UTC) #3
dfc
We have 10.6 and 10.7 darwin builders, the -race builder is 10.7. I'd like to ...
9 years, 4 months ago (2013-05-14 19:30:42 UTC) #4
amerine
On Tue, May 14, 2013 at 12:30 PM, Dave Cheney <dave@cheney.net> wrote: > We have ...
9 years, 4 months ago (2013-05-14 20:00:41 UTC) #5
dfc
The code for the builders is in $GOROOT/misc/dashboard/builder. They all run ./all.{bash,bat} (unless their build ...
9 years, 4 months ago (2013-05-14 20:06:01 UTC) #6
amerine
On 2013/05/14 20:06:01, dfc wrote: > The code for the builders is in $GOROOT/misc/dashboard/builder. They ...
9 years, 4 months ago (2013-05-14 20:35:10 UTC) #7
minux1
On Wed, May 15, 2013 at 4:35 AM, <mark@amerine.net> wrote: > `run.bash: line 20: ulimit: ...
9 years, 4 months ago (2013-05-14 20:57:52 UTC) #8
amerine
On 2013/05/14 20:57:52, minux wrote: > what does "ulimit -n -H" say on your system? ...
9 years, 4 months ago (2013-05-14 21:09:35 UTC) #9
dfc
ping. I do not see what this CL fixes. None of our builders are broken ...
9 years, 4 months ago (2013-05-22 01:21:13 UTC) #10
amerine
On 2013/05/22 01:21:13, dfc wrote: > ping. > > I do not see what this ...
9 years, 4 months ago (2013-05-22 01:46:44 UTC) #11
dfc
Given how many people on the Go team use darwin, I'm confident this isn't a ...
9 years, 4 months ago (2013-05-22 01:47:32 UTC) #12
amerine
On 2013/05/22 01:47:32, dfc wrote: > Given how many people on the Go team use ...
9 years, 4 months ago (2013-05-22 09:16:34 UTC) #13
minux1
https://codereview.appspot.com/9324044/diff/4001/src/run.bash File src/run.bash (right): https://codereview.appspot.com/9324044/diff/4001/src/run.bash#newcode21 src/run.bash:21: ([ "$(ulimit -H -n)" == "unlimited" ] || ulimit ...
9 years, 4 months ago (2013-05-22 16:41:27 UTC) #14
amerine
https://codereview.appspot.com/9324044/diff/4001/src/run.bash File src/run.bash (right): https://codereview.appspot.com/9324044/diff/4001/src/run.bash#newcode21 src/run.bash:21: ([ "$(ulimit -H -n)" == "unlimited" ] || ulimit ...
9 years, 4 months ago (2013-05-22 16:54:50 UTC) #15
rsc
R=close
8 years, 9 months ago (2013-12-18 04:16:23 UTC) #16
tim.olsen
I've seen this error on Mac OS X 10.9.1
8 years, 7 months ago (2014-02-20 20:28:31 UTC) #17
amerine
On 2014/02/20 20:28:31, tim.olsen_10gen.com wrote: > I've seen this error on Mac OS X 10.9.1 ...
8 years, 7 months ago (2014-02-21 00:14:58 UTC) #18
dfc
Tim, could you please distill this conversation into an issue, golang.org/issue/new. As far as I ...
8 years, 7 months ago (2014-02-21 00:16:43 UTC) #19
tim.olsen_mongodb.com
8 years, 7 months ago (2014-02-21 15:32:36 UTC) #20
New issue created: https://code.google.com/p/go/issues/detail?id=7381

Tim


On Thu, Feb 20, 2014 at 7:16 PM, Dave Cheney <dave@cheney.net> wrote:

> Tim, could you please distill this conversation into an issue,
> golang.org/issue/new. As far as I am aware, Go builds fine from source on
> many darwin machines without any tweaking of the ulimit tunables.
>
>
> On Fri, Feb 21, 2014 at 11:14 AM, <mark@amerine.net> wrote:
>
>> On 2014/02/20 20:28:31, tim.olsen_10gen.com wrote:
>>
>>> I've seen this error on Mac OS X 10.9.1
>>>
>>
>> Yes, I can replicate as well. As I mentioned back in May, a system with
>> the hard and soft limits set in /etc/launchd.conf can cause go to fail
>> building on Darwin.
>>
>> https://codereview.appspot.com/9324044/
>>
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b