Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(58)

Issue 93030043: code review 93030043: go.talks/present: use new socket interface (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by adg
Modified:
6 years, 8 months ago
Reviewers:
rsc, bradfitz
CC:
rsc, golang-codereviews
Visibility:
Public.

Description

go.talks/present: use new socket interface

Patch Set 1 #

Patch Set 2 : diff -r 04e1fc800c71 https://code.google.com/p/go.talks #

Patch Set 3 : diff -r bb47523571ee https://code.google.com/p/go.talks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M present/local.go View 1 2 chunks +9 lines, -1 line 1 comment Download

Messages

Total messages: 4
rsc
LGTM
6 years, 8 months ago (2014-05-05 15:21:46 UTC) #1
adg
Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.talks
6 years, 8 months ago (2014-05-05 15:42:49 UTC) #2
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=f19c3f34b550&repo=talks *** go.talks/present: use new socket interface LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/93030043
6 years, 8 months ago (2014-05-05 15:42:53 UTC) #3
bradfitz
6 years, 8 months ago (2014-05-05 16:52:49 UTC) #4
Message was sent while issue was closed.
https://codereview.appspot.com/93030043/diff/40001/present/local.go
File present/local.go (right):

https://codereview.appspot.com/93030043/diff/40001/present/local.go#newcode65
present/local.go:65: origin := &url.URL{Scheme: "http", Host: host + ":" + port}
JoinHostPort?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b