Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1316)

Issue 92770043: Deduplicate remote_api.py code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by vadimsh
Modified:
9 years, 12 months ago
Reviewers:
csharp, M-A
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming/@master
Visibility:
Public.

Description

Deduplicate remote_api.py code. Isolate and swarming apps used to have different implementations of remote_api.py. Now they defer to components/tools/remote_api.py (that can also be invoked as a standalone script). Also add readline support with command history, just like in standard remote_api_shell.py GAE tool. R=csharp@chromium.org, maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=5323d95

Patch Set 1 #

Total comments: 2

Patch Set 2 : make more useful as a standalone script #

Patch Set 3 : remove app_dir from context scope #

Patch Set 4 : nits in comment #

Total comments: 8

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -451 lines) Patch
A + services/components/tools/remote_api.py View 1 2 3 4 6 chunks +101 lines, -69 lines 0 comments Download
M services/components/tools/update.py View 1 2 3 4 1 chunk +8 lines, -8 lines 0 comments Download
M services/isolate/tools/remote_api.py View 1 1 chunk +19 lines, -201 lines 0 comments Download
M services/swarming/tools/remote_api.py View 1 1 chunk +26 lines, -173 lines 0 comments Download

Messages

Total messages: 6
vadimsh
https://codereview.appspot.com/92770043/diff/1/services/components/tools/remote_api.py File services/components/tools/remote_api.py (right): https://codereview.appspot.com/92770043/diff/1/services/components/tools/remote_api.py#newcode144 services/components/tools/remote_api.py:144: auth = KeyringAuth('remote_api_pwd_%s' % socket.getfqdn()) You'd have to reenter ...
9 years, 12 months ago (2014-04-25 03:21:26 UTC) #1
vadimsh
ping in case you've missed this
9 years, 12 months ago (2014-04-25 18:18:47 UTC) #2
csharp
(reviewing for M-A so he can focus on all the swarm cl comments I gave ...
9 years, 12 months ago (2014-04-25 18:30:54 UTC) #3
vadimsh
https://codereview.appspot.com/92770043/diff/60001/services/components/tools/remote_api.py File services/components/tools/remote_api.py (right): https://codereview.appspot.com/92770043/diff/60001/services/components/tools/remote_api.py#newcode198 services/components/tools/remote_api.py:198: if not app_dir: On 2014/04/25 18:30:54, csharp wrote: > ...
9 years, 12 months ago (2014-04-25 19:43:48 UTC) #4
csharp
lgtm
9 years, 12 months ago (2014-04-25 19:49:09 UTC) #5
vadimsh
9 years, 12 months ago (2014-04-25 20:46:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r5323d95 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b