Issue 92700043: Comment improvements relating to upgrades

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92700043: Comment improvements relating to upgrades

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by menn0

Modified:
9 years, 10 months ago

Reviewers:
wwitzel3, mp+221354, fwereade

Visibility:
Public.

Description

Comment improvements relating to upgrades A comment correction and a comment addition relating to different bits of upgrade infrastructure (I've been learning how juju upgrades work). https://code.launchpad.net/~menno.smits/juju-core/upgrade-comments/+merge/221354 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/machine.go	View	1 chunk	+2 lines, -1 line	2 comments	Download
M	state/apiserver/upgrader/upgrader.go	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

wwitzel3

LGTM just had a trivial non-blocking comment. https://codereview.appspot.com/92700043/diff/1/cmd/jujud/machine.go File cmd/jujud/machine.go (right): https://codereview.appspot.com/92700043/diff/1/cmd/jujud/machine.go#newcode696 cmd/jujud/machine.go:696: // If ...

9 years, 10 months ago (2014-05-30 16:44:32 UTC) #3

menn0

9 years, 10 months ago (2014-06-02 22:07:31 UTC) #4

https://codereview.appspot.com/92700043/diff/1/cmd/jujud/machine.go
File cmd/jujud/machine.go (right):

https://codereview.appspot.com/92700043/diff/1/cmd/jujud/machine.go#newcode696
cmd/jujud/machine.go:696: // If the machine agent is a state server, open state
before
On 2014/05/30 16:44:31, wwitzel3 wrote:
> The comment threw me a bit, I feel like it should read something like flag
> needState or what have you, since the the loop isn't actually doing the
opening,
> that is happening on #714 after checking needState *shrug*

I've (hopefully) clarified the comment. Thanks.

Expand All Messages | Collapse All Messages