Issue 92220043: code review 92220043: go.crypto/ssh/terminal: support ^U, ^D and ^L.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 92220043: code review 92220043: go.crypto/ssh/terminal: support ^U, ^D and ^L. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by agl1

Modified:
9 years, 11 months ago

Reviewers:
bradfitz

CC:
bradfitz, marios.nikolaou, golang-codereviews

Visibility:
Public.

Description

go.crypto/ssh/terminal: support ^U, ^D and ^L.

Patch Set 2 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Total comments: 2

Patch Set 4 : diff -r d88182750244 https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 447cf0eb2101 https://code.google.com/p/go.crypto/ #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	ssh/terminal/terminal.go	View	1 2 3	5 chunks	+24 lines, -1 line	0 comments	Download
	M	ssh/terminal/terminal_test.go	View	1	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/

9 years, 11 months ago (2014-05-10 23:14:50 UTC) #1

marios.nikolaou

https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go#newcode461 ssh/terminal/terminal.go:461: // Erase the charactor under the current position. Should ...

9 years, 11 months ago (2014-05-11 09:13:59 UTC) #2

agl1

9 years, 11 months ago (2014-05-13 03:21:05 UTC) #3

agl1

9 years, 11 months ago (2014-05-28 02:45:35 UTC) #6

*** Submitted as
https://code.google.com/p/go/source/detail?r=8a278ade38cb&repo=crypto ***

go.crypto/ssh/terminal: support ^U, ^D and ^L.

LGTM=bradfitz
R=bradfitz, marios.nikolaou
CC=golang-codereviews
https://codereview.appspot.com/92220043

Expand All Messages | Collapse All Messages