Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2123)

Issue 92220043: code review 92220043: go.crypto/ssh/terminal: support ^U, ^D and ^L. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by agl1
Modified:
6 years, 9 months ago
Reviewers:
bradfitz
CC:
bradfitz, marios.nikolaou, golang-codereviews
Visibility:
Public.

Description

go.crypto/ssh/terminal: support ^U, ^D and ^L.

Patch Set 1 #

Patch Set 2 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Patch Set 3 : diff -r fe6c00a82e55 https://code.google.com/p/go.crypto/ #

Total comments: 2

Patch Set 4 : diff -r d88182750244 https://code.google.com/p/go.crypto/ #

Patch Set 5 : diff -r 447cf0eb2101 https://code.google.com/p/go.crypto/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M ssh/terminal/terminal.go View 1 2 3 5 chunks +24 lines, -1 line 0 comments Download
M ssh/terminal/terminal_test.go View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6
agl1
Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto/
6 years, 9 months ago (2014-05-10 23:14:50 UTC) #1
marios.nikolaou
https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go#newcode461 ssh/terminal/terminal.go:461: // Erase the charactor under the current position. Should ...
6 years, 9 months ago (2014-05-11 09:13:59 UTC) #2
agl1
https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go File ssh/terminal/terminal.go (right): https://codereview.appspot.com/92220043/diff/40001/ssh/terminal/terminal.go#newcode461 ssh/terminal/terminal.go:461: // Erase the charactor under the current position. On ...
6 years, 9 months ago (2014-05-13 03:21:05 UTC) #3
agl1
bradfitz ping.
6 years, 9 months ago (2014-05-25 20:52:48 UTC) #4
bradfitz
LGTM
6 years, 9 months ago (2014-05-26 14:15:17 UTC) #5
agl1
6 years, 9 months ago (2014-05-28 02:45:35 UTC) #6
*** Submitted as
https://code.google.com/p/go/source/detail?r=8a278ade38cb&repo=crypto ***

go.crypto/ssh/terminal: support ^U, ^D and ^L.

LGTM=bradfitz
R=bradfitz, marios.nikolaou
CC=golang-codereviews
https://codereview.appspot.com/92220043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b