Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 92160043: Split out Ubuntu series lookup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by wallyworld
Modified:
6 years, 4 months ago
Reviewers:
mp+218910, axw
Visibility:
Public.

Description

Split out Ubuntu series lookup Support for querying Ubuntu series info was in the simplestreams package. We needed to add support for "utopic" but it wasn't obvious where to do it. A previous attempt was made but only a test constant was changed. This branch extracts the series stuff into a new juju/ubuntu package and adds proper "utopic" support. We may well need to look at this again when we want to add supported series support for other OS's but for now this should be good enough. https://code.launchpad.net/~wallyworld/juju-core/utopic-support/+merge/218910 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -145 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/bootstrap/synctools.go View 2 chunks +2 lines, -2 lines 0 comments Download
M environs/imagemetadata/generate.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/imagemetadata/simplestreams.go View 3 chunks +3 lines, -2 lines 0 comments Download
M environs/simplestreams/export_test.go View 1 chunk +0 lines, -11 lines 0 comments Download
M environs/simplestreams/simplestreams.go View 2 chunks +0 lines, -102 lines 0 comments Download
M environs/simplestreams/simplestreams_test.go View 3 chunks +0 lines, -21 lines 0 comments Download
M environs/simplestreams/testing/testing.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/sync/sync.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/tools/simplestreams.go View 3 chunks +3 lines, -2 lines 0 comments Download
M environs/tools/testing/testing.go View 2 chunks +2 lines, -1 line 0 comments Download
M environs/tools/tools.go View 2 chunks +2 lines, -1 line 0 comments Download
A juju/ubuntu/export_test.go View 1 chunk +15 lines, -0 lines 0 comments Download
A juju/ubuntu/package_test.go View 1 chunk +14 lines, -0 lines 0 comments Download
A juju/ubuntu/supportedseries.go View 1 chunk +116 lines, -0 lines 0 comments Download
A juju/ubuntu/supportedseries_test.go View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
6 years, 4 months ago (2014-05-09 04:46:47 UTC) #1
axw
On 2014/05/09 04:46:47, wallyworld wrote: > Please take a look. I think version/ubuntu would be ...
6 years, 4 months ago (2014-05-09 04:56:51 UTC) #2
wallyworld
6 years, 4 months ago (2014-05-09 05:03:18 UTC) #3
On 2014/05/09 04:56:51, axw wrote:
> On 2014/05/09 04:46:47, wallyworld wrote:
> > Please take a look.
> 
> I think version/ubuntu would be even more obvious. Otherwise, LGTM.

Yeah, good idea. Done
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b