Issue 9207050: FIXES: #1175975 1177456 1178429 1180601 Design cha

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9207050: FIXES: #1175975 1177456 1178429 1180601 Design cha (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by huwshimi

Modified:
10 years, 10 months ago

Reviewers:
curtis, mp+164065, gary.poster

Visibility:
Public.

Description

FIXES: #1175975 1177456 1178429 1180601 Design cha - Charm details show close button instead of back button in sidebar mode. - Fixed charm tokens from wrapping copy on fullscreen homepage for small screen sizes. - Added missing hover states to browser section headers. - Set sidebar to flexible width. https://code.launchpad.net/~huwshimi/juju-gui/another-set-of-design-fixes/+merge/164065 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : FIXES: #1175975 1177456 1178429 1180601 Design cha #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 chunk	+6 lines, -2 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/views/browser/main.less	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	lib/views/browser/section-title.less	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

Code LGTM. Will QA if requested but deferring to Orange atm. Thank you! Gary

10 years, 11 months ago (2013-05-16 12:36:20 UTC) #2

curtis

Thank you Huw. LGTM. Sorry about the delay. I has planning work and broken juju-gui ...

10 years, 11 months ago (2013-05-20 20:15:31 UTC) #3

huwshimi

10 years, 11 months ago (2013-05-21 03:05:11 UTC) #4

*** Submitted:

FIXES: #1175975 1177456 1178429 1180601 Design cha

- Charm details show close button instead of back button in sidebar mode.
- Fixed charm tokens from wrapping copy on fullscreen homepage for small screen
sizes.
- Added missing hover states to browser section headers.
- Set sidebar to flexible width.

R=gary.poster, curtis
CC=
https://codereview.appspot.com/9207050

Expand All Messages | Collapse All Messages