Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(246)

Issue 9207045: Remove appcache

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by matthew.scott
Modified:
10 years, 11 months ago
Reviewers:
mp+163776, bcsaller, gary.poster
Visibility:
Public.

Description

Remove appcache The HTML5 Application Cache will no longer be pertinent with upcoming design changes. Additionally, it was causing the site to fall over in various ways as time passed or after the config-changed hook was executed. This MP is sort of "half WIP", as the QA aspect will take some time to observe. To that end, I've set up a QA instance at https://ec2-54-243-27-37.compute-1.amazonaws.com/ that we can keep an eye on and play around with. If things look good as compared to http://tinyurl.com/jujucharms, then we can consider landing. https://code.launchpad.net/~makyo/juju-gui/remove-appcache2/+merge/164413 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove appcache #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -81 lines) Patch
M HACKING View 1 1 chunk +0 lines, -39 lines 0 comments Download
M Makefile View 1 6 chunks +13 lines, -30 lines 0 comments Download
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
D manifest.appcache.in View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 5
matthew.scott
Please take a look.
10 years, 11 months ago (2013-05-14 16:59:34 UTC) #1
gary.poster
Code LGTM. Ack on the QA; sounds like a good approach. I'll reply back if ...
10 years, 11 months ago (2013-05-14 18:05:02 UTC) #2
bcsaller
LGTM I thought the plan was to conditionally remove this on debug builds, but it ...
10 years, 11 months ago (2013-05-14 18:11:08 UTC) #3
gary.poster
land it! :-)
10 years, 11 months ago (2013-05-17 00:05:54 UTC) #4
matthew.scott
10 years, 11 months ago (2013-05-17 14:45:53 UTC) #5
*** Submitted:

Remove appcache

The HTML5 Application Cache will no longer be pertinent with upcoming design
changes.  Additionally, it was causing the site to fall over in various ways as
time passed or after the config-changed hook was executed.  This MP is sort of
"half WIP", as the QA aspect will take some time to observe.  To that end, I've
set up a QA instance at https://ec2-54-243-27-37.compute-1.amazonaws.com/ that
we can keep an eye on and play around with.  If things look good as compared to
http://tinyurl.com/jujucharms, then we can consider landing.

R=gary.poster, bcsaller
CC=
https://codereview.appspot.com/9207045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b