Issue 91820043: code review 91820043: goprotobuf: Fix proto.Merge handling of scalar bytes fields.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91820043: code review 91820043: goprotobuf: Fix proto.Merge handling of scalar bytes fields. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dsymonds

Modified:
11 years, 6 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Fix proto.Merge handling of scalar bytes fields. Previously the []byte would be treated as a repeated field, and the new data would be appended. However, []byte is a scalar field and the old data should be replaced instead. Fixes issue 51.

Patch Set 1 #

Patch Set 2 : diff -r ec8a922f81f6 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r ec8a922f81f6 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r ec8a922f81f6 https://code.google.com/p/goprotobuf #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	proto/clone.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
	M	proto/clone_test.go	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

11 years, 6 months ago (2014-04-26 16:26:42 UTC) #1

dsymonds

11 years, 6 months ago (2014-04-26 16:28:00 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=556b9de4249f ***

goprotobuf: Fix proto.Merge handling of scalar bytes fields.

Previously the []byte would be treated as a repeated field,
and the new data would be appended. However, []byte is a
scalar field and the old data should be replaced instead.

Fixes issue 51.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/91820043

Expand All Messages | Collapse All Messages