Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10107)

Issue 91790044: Move run_dev_appserver.py to components/tools and make it reusable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 12 months ago by vadimsh
Modified:
9 years, 12 months ago
Reviewers:
M-A
CC:
swarming-eng_googlegroups.com
Base URL:
https://code.google.com/p/swarming/@master
Visibility:
Public.

Description

Move run_dev_appserver.py to components/tools and make it reusable. Also add a corresponding wrapper script swarming/tools/. R=maruel@chromium.org BUG= Committed: https://code.google.com/p/swarming/source/detail?repo=default&r=b2014ba

Patch Set 1 #

Total comments: 9

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -40 lines) Patch
A services/components/tools/run_dev_appserver.py View 1 1 chunk +75 lines, -0 lines 0 comments Download
M services/isolate/tools/run_dev_appserver.py View 1 chunk +3 lines, -35 lines 0 comments Download
A + services/swarming/tools/run_dev_appserver.py View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 5
vadimsh
ptal switch.py is probably next. https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py File services/components/tools/run_dev_appserver.py (right): https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py#newcode8 services/components/tools/run_dev_appserver.py:8: This script is mostly ...
9 years, 12 months ago (2014-04-25 04:21:12 UTC) #1
M-A
lgtm with a few nits https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py File services/components/tools/run_dev_appserver.py (right): https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py#newcode33 services/components/tools/run_dev_appserver.py:33: help='Path to AppEngine SDK. ...
9 years, 12 months ago (2014-04-25 12:56:54 UTC) #2
vadimsh
https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py File services/components/tools/run_dev_appserver.py (right): https://codereview.appspot.com/91790044/diff/1/services/components/tools/run_dev_appserver.py#newcode33 services/components/tools/run_dev_appserver.py:33: help='Path to AppEngine SDK. Will try to find by ...
9 years, 12 months ago (2014-04-25 21:02:18 UTC) #3
M-A
https://codereview.appspot.com/91790044/diff/1/services/isolate/tools/run_dev_appserver.py File services/isolate/tools/run_dev_appserver.py (right): https://codereview.appspot.com/91790044/diff/1/services/isolate/tools/run_dev_appserver.py#newcode13 services/isolate/tools/run_dev_appserver.py:13: sys.path.insert(0, os.path.join(APP_DIR, '..', 'components', 'third_party')) On 2014/04/25 21:02:19, vadimsh ...
9 years, 12 months ago (2014-04-25 21:20:14 UTC) #4
vadimsh
9 years, 12 months ago (2014-04-25 21:33:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as rb2014ba.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b