Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(842)

Issue 91790043: Document the JDBC 4.0 requirement in DatabaseConnectionPool (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by JohnL
Modified:
9 years, 11 months ago
Reviewers:
Tanmay Vartak, brett.michael.johnson
CC:
connector-cr_google.com
Base URL:
http://google-enterprise-connector-manager.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Document the JDBC 4.0 requirement in DatabaseConnectionPool. This is a followup to r3315, which added a call to Connection.isValid.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M projects/connector-manager/source/java/com/google/enterprise/connector/util/database/DatabaseConnectionPool.java View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
JohnL
9 years, 11 months ago (2014-04-25 01:40:46 UTC) #1
JohnL
+Brett as an alternative reviewer
9 years, 11 months ago (2014-04-25 03:18:24 UTC) #2
Tanmay Vartak
On 2014/04/25 03:18:24, John L wrote: > +Brett as an alternative reviewer LGTM
9 years, 11 months ago (2014-04-25 18:19:14 UTC) #3
JohnL
9 years, 11 months ago (2014-04-25 21:32:16 UTC) #4

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b