Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 91700043: cmd/jujud: unskip TestManageEnvironServesAPI

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by axw
Modified:
9 years, 10 months ago
Reviewers:
mp+220900, fwereade
Visibility:
Public.

Description

cmd/jujud: unskip TestManageEnvironServesAPI This test has been skipped due to unreliability, but nobody ever went back and looked at fixing it. I can't see anything obviously wrong, and I can't reproduce the failure on trunk. Reenabling for now, will revert this change if the bot starts failing again. https://code.launchpad.net/~axwalk/juju-core/unskip-testmanagenenvironservesapi/+merge/220900 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/machine_test.go View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3
axw
Please take a look.
9 years, 10 months ago (2014-05-26 06:04:15 UTC) #1
fwereade
LGTM, speculatively, but please be careful to land it when you'll be around for a ...
9 years, 10 months ago (2014-05-26 06:23:34 UTC) #2
axw
9 years, 10 months ago (2014-05-26 06:29:57 UTC) #3
On 2014/05/26 06:23:34, fwereade wrote:
> LGTM, speculatively, but please be careful to land it when you'll be around
for
> a few hours to watch what happens. The most annoying possibility is that it'll
> pass randomly the one time it needs to get into trunk, and I'd like to back it
> out asap if it's a problem.

Will be around for a few hours yet.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b